From: Yao Qi <qiyaoltc@gmail.com>
To: Don Breazeal <donb@codesourcery.com>
Cc: "Gustavo\, Luis" <Luis_Gustavo@mentor.com>,
"gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Eliminate -var-create error for optzd ptr to struct
Date: Tue, 29 Mar 2016 12:01:00 -0000 [thread overview]
Message-ID: <86r3etsdbh.fsf@gmail.com> (raw)
In-Reply-To: <56CDDAEE.1030504@codesourcery.com> (Don Breazeal's message of "Wed, 24 Feb 2016 08:31:42 -0800")
Don Breazeal <donb@codesourcery.com> writes:
>>> @@ -1203,9 +1203,10 @@ value_actual_type (struct value *value, int resolve_simple_types,
>>> /* If result's target type is TYPE_CODE_STRUCT, proceed to
>>> fetch its rtti type. */
>>> if ((TYPE_CODE (result) == TYPE_CODE_PTR
>>> - || TYPE_CODE (result) == TYPE_CODE_REF)
>>> + || TYPE_CODE (result) == TYPE_CODE_REF)
>>
>> Is this just a formatting change?
>
> Yes. I should have documented that in the ChangeLog.
If it is just a format change, you can move it to a separate patch, and
commit it as obvious. Don't mix format change with your bug fix patch.
--
Yao (齐尧)
next prev parent reply other threads:[~2016-03-29 12:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-24 0:19 Don Breazeal
2016-02-24 1:14 ` Luis Machado
2016-02-24 16:31 ` Don Breazeal
2016-02-25 12:22 ` Pedro Alves
2016-03-28 21:33 ` [PATCH v2 0/2] Optzd-out ptr: Error handling improvement Don Breazeal
2016-03-28 21:34 ` [PATCH v2 2/2] Optzd-out ptr: Eliminate -var-create error Don Breazeal
2016-03-28 21:34 ` [PATCH v2 1/2] Optzd-out ptr: New test for error handling Don Breazeal
2016-03-29 11:58 ` Yao Qi
2016-03-29 17:13 ` Don Breazeal
2016-03-30 14:37 ` Yao Qi
2016-04-06 21:34 ` Don Breazeal
2016-03-29 12:01 ` Yao Qi [this message]
2016-03-29 17:14 ` [PATCH] Eliminate -var-create error for optzd ptr to struct Don Breazeal
2016-03-30 14:35 ` Yao Qi
2016-04-01 16:01 ` Don Breazeal
2016-04-04 10:42 ` Yao Qi
2016-04-04 17:16 ` Don Breazeal
2016-04-04 21:28 ` Don Breazeal
2016-04-05 12:53 ` Yao Qi
2016-04-05 18:51 ` Don Breazeal
2016-04-05 19:00 ` Pedro Alves
2016-04-05 20:39 ` Don Breazeal
2016-04-06 9:05 ` Yao Qi
2016-04-06 21:41 ` Don Breazeal
2016-04-06 22:24 ` Pedro Alves
2016-04-07 14:12 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86r3etsdbh.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=Luis_Gustavo@mentor.com \
--cc=donb@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).