From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73518 invoked by alias); 16 Oct 2017 09:33:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73504 invoked by uid 89); 16 Oct 2017 09:33:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:sk:static. X-HELO: mail-wm0-f54.google.com Received: from mail-wm0-f54.google.com (HELO mail-wm0-f54.google.com) (74.125.82.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Oct 2017 09:33:36 +0000 Received: by mail-wm0-f54.google.com with SMTP id 196so4051235wma.1 for ; Mon, 16 Oct 2017 02:33:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=Q4s83Zj0O/yT3gA3d0aTwhNAhd/Ru2hVlxPyWmbOMBo=; b=kDBDtgzMdRPiEmYnmDCTDjuYRpeTgSD7mWzW9qQeY4mpyNK2s+cl559nKDWyzOxArk Gf4vN2l8XSoSIioptRNREbln/Tg33c5qCAn6uLSJZM6zMAapfD4HFfnmJs3Ko0KoQUCR aB3w6I2mGyjzV6YT+j/7gxJYf7SZdo7dx0ZmtfWWfVrdTiraFvIUeXR7o3zt7L+bSUiL Pehk85BfzmjOFa4SEARgWOz1IlI8TP7tcAWR+o2s5RDjfLTmWDqAlx+BtSai0pIXIwV0 nhf36IUfttfabq4bO1l41w2m0AUHslFfMsB1pK2Z8puYjIBGVqDXa5A+Hc4OIts6dyt2 ZyYw== X-Gm-Message-State: AMCzsaVF0fv4E6kcngG/e0KX8yMD3yTPZfUvlD+XG1UoYjYmTLaWiwdV zW1ubRrPtUToNZloQy+5RmJj+Q== X-Google-Smtp-Source: ABhQp+SAX4YlUIKgbAGIoL4/KrHv6cJHi9+TF5ocheg3D+aMQ9GBglC0msLfFV1vIM1O5Yc6lhII9A== X-Received: by 10.28.71.25 with SMTP id u25mr304757wma.126.1508146414074; Mon, 16 Oct 2017 02:33:34 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id o76sm4247667wrb.48.2017.10.16.02.33.33 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 16 Oct 2017 02:33:33 -0700 (PDT) From: Yao Qi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 4/8] Make strip_bg_char return a unique_xmalloc_ptr References: <20171013205950.22943-1-tom@tromey.com> <20171013205950.22943-5-tom@tromey.com> Date: Mon, 16 Oct 2017 09:33:00 -0000 In-Reply-To: <20171013205950.22943-5-tom@tromey.com> (Tom Tromey's message of "Fri, 13 Oct 2017 14:59:46 -0600") Message-ID: <86shejwi6t.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00423.txt.bz2 Tom Tromey writes: > - args =3D strip_bg_char (args, &async_exec); > - args_chain =3D make_cleanup (xfree, args); > + gdb::unique_xmalloc_ptr stripped =3D strip_bg_char (args, &async= _exec); > + args =3D stripped.get (); >=20=20 > /* Do validation and preparation before possibly changing anything > in the inferior. */ > @@ -663,9 +663,6 @@ run_command_1 (char *args, int from_tty, enum run_how= run_how) > uiout->flush (); > } >=20=20 > - /* Done with ARGS. */ > - do_cleanups (args_chain); > - My concern is that we may leak something if some cleanups are registered to the cleanup chain in the callees between make_cleanup and do_cleanups here. However, I am not sure how to detect that. --=20 Yao (=E9=BD=90=E5=B0=A7)