* [PATCH] Use value_contents instead of value_contents_writeable
@ 2015-11-13 9:59 Yao Qi
2015-11-16 14:48 ` Yao Qi
0 siblings, 1 reply; 2+ messages in thread
From: Yao Qi @ 2015-11-13 9:59 UTC (permalink / raw)
To: gdb-patches
Both aarch64_push_dummy_call and bfin_push_dummy_call only use value
contents but then never write to them, so that we can use
value_contents instead.
Regression tested on aarch64-linux only. No bfin box to test.
gdb:
2015-11-13 Yao Qi <yao.qi@linaro.org>
* aarch64-tdep.c (aarch64_push_dummy_call): Call value_contents instead
of value_contents_writeable.
* bfin-tdep.c (bfin_push_dummy_call): Likewise.
---
gdb/aarch64-tdep.c | 2 +-
gdb/bfin-tdep.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index bc282e9..553a420 100644
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -1300,7 +1300,7 @@ aarch64_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
check_typedef (value_type (field));
pass_in_v_or_stack (gdbarch, regcache, &info, field_type,
- value_contents_writeable (field));
+ value_contents (field));
}
}
else
diff --git a/gdb/bfin-tdep.c b/gdb/bfin-tdep.c
index 1d48225..54936cc 100644
--- a/gdb/bfin-tdep.c
+++ b/gdb/bfin-tdep.c
@@ -531,7 +531,7 @@ bfin_push_dummy_call (struct gdbarch *gdbarch,
int container_len = (TYPE_LENGTH (value_type) + 3) & ~3;
sp -= container_len;
- write_memory (sp, value_contents_writeable (args[i]), container_len);
+ write_memory (sp, value_contents (args[i]), container_len);
}
/* Initialize R0, R1, and R2 to the first 3 words of parameters. */
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Use value_contents instead of value_contents_writeable
2015-11-13 9:59 [PATCH] Use value_contents instead of value_contents_writeable Yao Qi
@ 2015-11-16 14:48 ` Yao Qi
0 siblings, 0 replies; 2+ messages in thread
From: Yao Qi @ 2015-11-16 14:48 UTC (permalink / raw)
To: Yao Qi; +Cc: gdb-patches
Yao Qi <qiyaoltc@gmail.com> writes:
> gdb:
>
> 2015-11-13 Yao Qi <yao.qi@linaro.org>
>
> * aarch64-tdep.c (aarch64_push_dummy_call): Call value_contents instead
> of value_contents_writeable.
> * bfin-tdep.c (bfin_push_dummy_call): Likewise.
Patch is pushed in.
--
Yao (齐尧)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-16 14:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-13 9:59 [PATCH] Use value_contents instead of value_contents_writeable Yao Qi
2015-11-16 14:48 ` Yao Qi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).