From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id D567B3858D1E for ; Thu, 28 Mar 2024 14:01:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D567B3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D567B3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711634475; cv=none; b=qG/2VYbyHAQTj6Grq707ibrQZlavjvNiC9QDZZs152AML6YrBX52EyR6CR4DEaPRv+Rus9pkUsM0wWCSaq6kPKSQUZzMHuhDt8dbInOMnmdveoVn8WTMPXOc6f3IE7QiQOG5RHImgU1fJrVrCdjhVuaD6Q6sXeisEUZ9Ht0353M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711634475; c=relaxed/simple; bh=oB4a4WNpXVTOPHjJgrLLkrfMNLDbM2rGUy0mCoAwE84=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=jiNgqxhKa4U3CONmraMcrLiTYWoBEziv1yPT11v82iU1Uw9XNRCpoi4DFJ4sC5Kmu3w8zQH1iXuDPL5GDU8Dzevw+ztAjlZrn3gTLP7vTnaxh4POhNd6fyd2Wpr+MNvVjQeLT8FjcgakTo1Yuvwo5jH2Dd4PST+D3mvkBnwmuKI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rpqJd-00031y-0e; Thu, 28 Mar 2024 10:01:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=dL9xgIK7ksYRAbV5E010MifEhP6HogHuTHSedjJNZ7g=; b=h8kw7dGwlLba hFtKM+sTUSKiSfdqorZhiV8M80d48OOHMw9gZ8LwfVsMpJQ3gx4l0CznhRO5S37H2spNb0s7NHTa/ c26D4R1X8J3QoWk2v6xb58fa/CpPqMmftu+s1QeQpsEeM/k8QWQHUJ49kD5QYKPVFIONrjtMy4Vsd QuSYFJbOrun62i8hxjek53YKLBE9nlZrKPQuyQqxTUA9qjx51WMKDMlR5POpLvsDd3krmBROuK/R3 xP8wes6Cg3aEBVza96t+cBkyiZw4AhqbQ0RC2bmo2d1NtBgfO3x8f7k8ShAw5xfJ4awMo/4PgkQB7 1ONL9xuCkhxdipXbpc4F+A==; Date: Thu, 28 Mar 2024 16:01:07 +0200 Message-Id: <86ttkqfobg.fsf@gnu.org> From: Eli Zaretskii To: Abdul Basit Ijaz Cc: gdb-patches@sourceware.org, JiniSusan.George@amd.com, tom@tromey.com In-Reply-To: <20240328120528.30382-7-abdul.b.ijaz@intel.com> (message from Abdul Basit Ijaz on Thu, 28 Mar 2024 13:05:24 +0100) Subject: Re: [PATCH v6 06/10] gdb: Skip trampoline functions for the up command. References: <20240328120528.30382-1-abdul.b.ijaz@intel.com> <20240328120528.30382-7-abdul.b.ijaz@intel.com> X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Abdul Basit Ijaz > Cc: abdul.b.ijaz@intel.com, > JiniSusan.George@amd.com, > tom@tromey.com, > eliz@gnu.org > Date: Thu, 28 Mar 2024 13:05:24 +0100 > > gdb/doc/gdb.texinfo | 2 +- > gdb/stack.c | 7 +++++++ > gdb/testsuite/gdb.fortran/func-trampoline.exp | 12 ++++++++++-- > 3 files changed, 18 insertions(+), 3 deletions(-) > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 5782e06b91d..222faba5da3 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -6475,7 +6475,7 @@ DWARF trampolines marked via DW_AT_trampoline are supported by this. > When issuing a @code{backtrace}, if @code{skip-trampoline-functions} is set, > @value{GDBN} will skip trampoline frames while printing the stack. > > -When issuing a @code{finish} or @code{reverse-finish}, if > +When issuing a @code{finish}, @code{reverse-finish} or @code{up}, if > @code{skip-trampoline-functions} is set, @value{GDBN} will skip trampoline > frames while returning from the target function. The gdb.texinfo part is okay, thanks. Reviewed-By: Eli Zaretskii