From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123674 invoked by alias); 28 Jun 2017 08:06:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 123660 invoked by uid 89); 28 Jun 2017 08:06:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=HCc:D*ca, H*r:sk:static., letter, hear X-HELO: mail-io0-f169.google.com Received: from mail-io0-f169.google.com (HELO mail-io0-f169.google.com) (209.85.223.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Jun 2017 08:06:18 +0000 Received: by mail-io0-f169.google.com with SMTP id h134so31367441iof.2 for ; Wed, 28 Jun 2017 01:06:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=pOMSMhuBbPE9n99aHq70aJU6G3Tmu3qTTTrseYSPHBQ=; b=KA1o8hNQd7v6m1JL9GJ5SEm5Tncqk/el/dtXvmw/4yR0S3MWpnEZSL66EJVQoHg2lS SgJlztzFyuSQ7v5Iwxx1++9yYKonL6PKsGopYLL/lrd7thsTpdVOcR0SU3myw2yFIe60 ibZgL5OmEy09Po+V6fapxjeEHBMV6gaJ9qDcH5Yh/YmrDb4Kxl1bPZi5KlvkT19QoyrB cZYedo4oVynVW/LpzCNsDEZUKhy9qrFcMPFXI6fyBXjYKAKyMWs0x6VFTvkrA5GRU6Y1 bmtSUqJoPnzscFhhBmwjfTuRvbPipAftVEMk13jQCBpn4mGkknyZyGbABODcniU0TZBJ zd8A== X-Gm-Message-State: AKS2vOxwaL9UiBbdBP9p/afJg4HbmP9QAHGjaqgjzm4EyUCsSyXwtc/5 /wVJnNh2wAj6a9Zm X-Received: by 10.107.56.4 with SMTP id f4mr10525948ioa.86.1498637177057; Wed, 28 Jun 2017 01:06:17 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id o66sm2624555ito.2.2017.06.28.01.06.15 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 28 Jun 2017 01:06:16 -0700 (PDT) From: Yao Qi To: "Tedeschi\, Walfred" Cc: Simon Marchi , "gdb-patches\@sourceware.org" Subject: Re: [PATCH 00/25 V2] Make GDB builtin target descriptions more flexible References: <1497256916-4958-1-git-send-email-yao.qi@linaro.org> Date: Wed, 28 Jun 2017 08:06:00 -0000 In-Reply-To: (Walfred Tedeschi's message of "Mon, 26 Jun 2017 14:45:01 +0000") Message-ID: <86tw30edu2.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-06/txt/msg00758.txt.bz2 "Tedeschi, Walfred" writes: > Hello Yao, > > I did some tests and they are looking fine for remote and native gdb. > I could tweak the XCR0 in GDB and GDBSERVER and see tests that also use c= pu-id to detect features failing, as expected! Very nice! > Thanks again! Hi Walfred, Thanks for playing with these patches, and good to hear that you like it :) > > As an observation, in the gdbserver side there are calls to _get_ipa_tdes= c. I suppose we could rename this to a more generic name. > About the design: GDBserver still uses the combination of cpu features to= build the target description.=20 > On the other hand, the > improvement was huge, i.e. I would go to accept the patch and consider > an additional patch series to address gdbserver tdesc creation.=20 I would like GDBserver creates target description in the same way as GDB does, and then share the code creating target descriptions between GDB and GDBserver. It was mentioned in the bottom of cover letter, "share more code on creating x86-linux target descriptions in GDB and GDBserver" in next step. --=20 Yao (=E9=BD=90=E5=B0=A7)