public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: Yao Qi <qiyaoltc@gmail.com>,  gdb-patches@sourceware.org
Subject: Re: warning: Could not load shared library symbols for linux-vdso.so.1.
Date: Fri, 19 Aug 2016 09:59:00 -0000	[thread overview]
Message-ID: <86twehaxl3.fsf@gmail.com> (raw)
In-Reply-To: <96141d5a-3384-8314-1274-d1348dafe0c5@redhat.com> (Pedro Alves's	message of "Fri, 19 Aug 2016 02:04:59 +0100")

Pedro Alves <palves@redhat.com> writes:

> So I bit the bullet and made a custom Linux-specific
> struct solib_ops that inherits svr4_so_ops, and overrides a couple
> methods for vDSO awareness.  I think the end result is clearer
> and probably more extensible if/when we decide to do the work necessary
> to be able to show the vdso in "info sharedlibrary", without causing
> could-not-find-file warnings.
>
> I'm attaching two patches; the first implements the new solib_ops
> instance, and then the second uses the vDSO's bfd size, fixing the
> bug.
>
> Passes testing on x86_64 Fedora 23 here, as well as the new test.
>
> Let me know what you think.

They are good to me.  Do you plan to push them to 7.12 branch?  I'd like
to keep these patches in master only, because the problem they fix is
minor while the patches are not small changes.  What do you think?

-- 
Yao (齐尧)

  reply	other threads:[~2016-08-19  9:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-11 11:46 Yao Qi
2016-08-11 15:57 ` Pedro Alves
2016-08-12 10:28   ` Yao Qi
2016-08-19  1:05     ` Pedro Alves
2016-08-19  9:59       ` Yao Qi [this message]
2016-08-19 10:32         ` Pedro Alves
2016-08-19 11:41           ` Yao Qi
2016-08-19 14:02             ` Pedro Alves
2016-08-22  9:36               ` Yao Qi
2016-08-22 19:47                 ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86twehaxl3.fsf@gmail.com \
    --to=qiyaoltc@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).