From: Yao Qi <qiyaoltc@gmail.com>
To: Antoine Tremblay <antoine.tremblay@ericsson.com>
Cc: Yao Qi <qiyaoltc@gmail.com>, <gdb-patches@sourceware.org>
Subject: Re: [RFC 2/3] use reinsert breakpoint for vCont;s
Date: Thu, 12 May 2016 16:38:00 -0000 [thread overview]
Message-ID: <86twi3b5a1.fsf@gmail.com> (raw)
In-Reply-To: <wwokeg97l6fe.fsf@ericsson.com> (Antoine Tremblay's message of "Thu, 12 May 2016 10:03:33 -0400")
Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
> I though we would have to explicitly stop the threads, I'm curious has
> to where you moved it so that the threads are stopped ?
I moved the code deleting reinsert breakpoint to the place where
GDBserver is ready to report a stop back to GDB, because on this point,
all threads stop in all-stop mode, and the event thread stops in
no-stop mode. In non-stop mode, I delete the reinsert breakpoint of
event thread, while in all-stop mode, I delete the reinsert breakpoint
of all threads.
You are right that it is unsafe to remove reinsert breakpoint while some
threads are still running (in non-stop mode).
--
Yao (齐尧)
next prev parent reply other threads:[~2016-05-12 16:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 10:32 [RFC 0/3] Use " Yao Qi
2016-05-06 10:32 ` [RFC 1/3] make reinsert breakpoint thread specific Yao Qi
2016-05-06 10:32 ` [RFC 2/3] use reinsert breakpoint for vCont;s Yao Qi
2016-05-11 10:41 ` Yao Qi
2016-05-12 13:25 ` Antoine Tremblay
2016-05-13 12:12 ` Antoine Tremblay
2016-05-12 14:03 ` Antoine Tremblay
2016-05-12 16:38 ` Yao Qi [this message]
2016-05-06 10:32 ` [PATCH 3/3] [GDBserver] Support vCont s and S actions with software single step Yao Qi
2016-05-09 15:17 ` [RFC 0/3] Use reinsert breakpoint for vCont;s Antoine Tremblay
2016-05-10 13:29 ` Antoine Tremblay
2016-05-11 8:35 ` Yao Qi
2016-05-11 12:08 ` Antoine Tremblay
2016-05-17 14:08 ` Antoine Tremblay
2016-05-18 7:50 ` Yao Qi
2016-05-18 11:50 ` Antoine Tremblay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86twi3b5a1.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).