From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91787 invoked by alias); 10 Nov 2015 17:55:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91772 invoked by uid 89); 10 Nov 2015 17:55:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f46.google.com Received: from mail-pa0-f46.google.com (HELO mail-pa0-f46.google.com) (209.85.220.46) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Tue, 10 Nov 2015 17:55:53 +0000 Received: by pacdm15 with SMTP id dm15so3385862pac.3 for ; Tue, 10 Nov 2015 09:55:51 -0800 (PST) X-Received: by 10.68.130.69 with SMTP id oc5mr7529183pbb.140.1447178151785; Tue, 10 Nov 2015 09:55:51 -0800 (PST) Received: from E107787-LIN (gcc2-power8.osuosl.org. [140.211.9.43]) by smtp.gmail.com with ESMTPSA id jp1sm3102789pbc.54.2015.11.10.09.55.50 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 10 Nov 2015 09:55:51 -0800 (PST) From: Yao Qi To: Marcin =?utf-8?Q?Ko=C5=9Bcielnicki?= Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/2] gdb/testsuite/gdb.trace: Deduplicate pcreg/spreg/fpreg. References: <1447154499-22247-1-git-send-email-koriakin@0x04.net> <1447155300-22660-1-git-send-email-koriakin@0x04.net> Date: Tue, 10 Nov 2015 17:55:00 -0000 In-Reply-To: <1447155300-22660-1-git-send-email-koriakin@0x04.net> ("Marcin \=\?utf-8\?Q\?Ko\=C5\=9Bcielnicki\=22's\?\= message of "Tue, 10 Nov 2015 12:35:00 +0100") Message-ID: <86twotwxgb.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-11/txt/msg00262.txt.bz2 Marcin Ko=C5=9Bcielnicki writes: > gdb/testsuite/ChangeLog: > > * gdb.trace/backtrace.exp: Use global fpreg/spreg definition, add $ > in front. > * gdb.trace/change-loc.exp: Use global pcreg definition. > * gdb.trace/collection.exp: Use global pcreg/fpreg/spreg definition. > * gdb.trace/entry-values.exp: Use global spreg definition, add $ > in front. > * gdb.trace/mi-trace-frame-collected.exp: Use global pcreg definition. > * gdb.trace/pending.exp: Likewise. > * gdb.trace/report.exp: Use global pcreg/fpreg/spreg definition. > * gdb.trace/trace-break.exp: Likewise. > * gdb.trace/trace-condition.exp: Use global pcreg definition, add $ > in front. > * gdb.trace/unavailable.exp: Use global pcreg/fpreg/spreg definition. > * gdb.trace/while-dyn.exp: Use global fpreg definition, add $ > in front. > * lib/trace-support.exp: Define fpreg, spreg, pcreg variables. Looks good to me. Thanks. --=20 Yao (=E9=BD=90=E5=B0=A7)