From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 392543858D37 for ; Wed, 17 Apr 2024 19:26:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 392543858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 392543858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713381971; cv=none; b=VsKCRukt9VgejtE5VnQouC28+vb7aC8gKFAdlAazrPCjSdpQbiEUV+eBWpUQ5qEmuqSImn9M+nERelzLNdOgGM/Zljckp9XI9Np2eWoRcrmdB7gXfHJHTDFUw+g6fT/vEdOyiyhLN2pbuJ1DCEPJEPnTvoyS+rU5Gis4nN6WSyo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713381971; c=relaxed/simple; bh=SBpbDoUPWsv69eMoDPwTCt9nz77Eheu24n+2BMtYj3s=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=gw2/kzSQUmHihE2uZj4Bq6EC4szJMJO7E+j/s0uK8SX8/ibpIYYrVOPNG47c4WwQKyvZj50aj5rVF0/ruz0Dsy8JcH1rTUZnto+SkSVVzK3ToqTNzOZfm7NWp/RiZpfVuUClibcQdGiNqGhFK2pu5aS1aj5AT6Sd/4sZz7wBkHw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxAv0-000831-J3; Wed, 17 Apr 2024 15:26:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wQHOtRih0jESefX1kGzRcwPMjuiUmoDnfYTD84iP2ks=; b=jFcbSfubn34h r5Uyvrvdw9BurE6wSCnADHvB4u5ey5Canv+cRE+yZESifPUpDiT7JQp6pReeNivzEXn75FIL60VR3 CDGfS7QOuA4libR4R9wa/kq4kea+wE5yYG53rA8XVkh1lT27p7RKPExMteKBdisJIc53oVcDKjoqx s7pzHXY5PX8Zyi0WSIZj9n8qo83hb0uS9UJxIGhrniPCmYayiD86cRp5wzFHMrRHtOz7EbCcSUJDu 61T5jyYkTy7/QYB6pRt0rYjl2vmDatAB9FLZZmVcwoeoyqydnfP9hcanrSpH2IyCu+LBeSvVX8C46 a2H8ym5DKKaALfnbnyjpPw==; Date: Wed, 17 Apr 2024 22:26:03 +0300 Message-Id: <86v84fg59w.fsf@gnu.org> From: Eli Zaretskii To: Guinevere Larsen Cc: gdb-patches@sourceware.org, simark@simark.ca In-Reply-To: <3fea82e9-692a-4544-824e-33614a8eb8d5@redhat.com> (message from Guinevere Larsen on Wed, 17 Apr 2024 16:20:08 -0300) Subject: Re: [PATCH v2] gdb: Change "list ." command's error when no debuginfo is available References: <20240416200058.1300296-2-blarsen@redhat.com> <867cgwi4ji.fsf@gnu.org> <3fea82e9-692a-4544-824e-33614a8eb8d5@redhat.com> X-Spam-Status: No, score=-0.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Date: Wed, 17 Apr 2024 16:20:08 -0300 > Cc: gdb-patches@sourceware.org, simark@simark.ca > From: Guinevere Larsen > > On 4/17/24 08:58, Eli Zaretskii wrote: > >> From: Guinevere Larsen > >> Cc: Simon Marchi > >> Date: Tue, 16 Apr 2024 17:00:59 -0300 > >> > >> From: Simon Marchi > >> > >> Currently, when a user tries to list the current location, there are 2 > >> different error messages that can happen, either: > >> > >> (gdb) list . > >> No symbol table is loaded. Use the "file" command. > >> or > >> (gdb) list . > >> No debug information available to print source lines. > >> > >> The difference here is if gdb can find any symtabs at all or not, which > >> is not something too important for end-users - and isn't informative at > >> all. This commit changes it so that the error always says that there > >> isn't debug information available, with these two variants: > >> > >> (gdb) list . > >> No debug information available to print source lines at current PC (0x55555555511d). > >> or > >> (gdb) list . > >> No debug information available to print source lines at default location. > >> > >> The difference now is if the inferior has started already, which is > >> controlled by the user and may be useful. > > How about this text instead: > > > > Insufficient debug info for showing source lines at current PC (0x55555555511d). > > > You mean this change only for the error when the inferior has already > started, or to the prefix of both errors? > > Seeing as the errors are for the same root cause, I'd like to keep the > prefix the same. I'm afraid I don't understand what is the "prefix" in this case.