From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 816F9385840B for ; Tue, 16 Apr 2024 16:16:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 816F9385840B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 816F9385840B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713284185; cv=none; b=ZGDqf0m4U34h4wU/YNR1Jbie3lxQIN7LJTtSGueHF06cIQSHyrM2eyh0Hh8kre/8kOmHjeMh5e1/MFpwzeCh2JlhbGbWrJYB/TCCeF2SLPZ0IuEp4x54gzTxazvsGA9m1u0jcpkCZGdVSKILi/N/8BGwcsEyz4t2f6GTCh6kH2Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713284185; c=relaxed/simple; bh=RLvi6NII4A4Os446ifYbgkqhg0yezSdOJPtiKzWWT8E=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=GbpUqc7QaAsQiYPwTXWb+Mr7R81fLebrNG8VUUx7tAbRjqhQYkPR/J8uMCZHyHHJjjgljaucDiClVDE3ZiqZEouxNeS4A/WuwB4CLdAu/k0VdufaNY+r94XT6eneAevGyfW0lXw6eRUlSgmsjyV1dGtWweMVZ+qWyGhXYCYmIgo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwlTq-00028F-Er; Tue, 16 Apr 2024 12:16:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ciK4Kyv/+ErU4JTzWr//rYIvUnCRCTj7hsk6WQd/X3s=; b=XATVW9OthI6f aE9nsQMYrf9+B7bp9QatJALRlIO9jM5Ql9uAdhoP/GIXm/cw8PyTMWUCuaYMy+GFC2XRHxELBAthA WCCA43kHo4uybTHokkl2a2KFCEjJOJBrpwAxW5b+Jmx+1opyo/Ic99Lx24+mddvKyQ+AyGHkptnn3 Q/HDuBBnGErkbzC4MaKw5eoBVEKdKnSI9rUjza1wZ6tYUyDhiPtvzPv8z8b/Yo03nzZNvwVVxqPV8 O8QtsVZ81eG3F5QGO7BImpsgZR4HJ18/IlwkUTv1DzLOU4RNcW5+YPyuNsY/ybz8KaRZV43eJjKSD IMG4pHj0HtNvVZ5WWUR3aA==; Date: Tue, 16 Apr 2024 19:16:19 +0300 Message-Id: <86v84hi8q4.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: <0dfc55f1-3ce7-4fa9-af3a-f322df320b9b@simark.ca> (message from Simon Marchi on Tue, 16 Apr 2024 11:45:06 -0400) Subject: Re: [PATCH] Fix whitespace in "help set inferior-tty" References: <86wmoxict8.fsf@gnu.org> <0dfc55f1-3ce7-4fa9-af3a-f322df320b9b@simark.ca> X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Date: Tue, 16 Apr 2024 11:45:06 -0400 > From: Simon Marchi > > > > On 2024-04-16 10:48, Eli Zaretskii wrote: > > Hi, > > > > I've noticed that doc strings of "set inferior-tty" and "set cwd" have > > some excess whitespace, which makes them display with unexpected > > indentation, at least in a Windows command prompt window. The patch > > below fixes that. OK to install? > > I see the same problem. > > grepping around, I think I found more instances of the same problem: > > linux-nat.c:4704:Set debugging of GNU/Linux native target."), _(" \ > linux-nat.c:4705:Show debugging of GNU/Linux native target."), _(" \ > riscv-tdep.c:4824:Set debugger's use of compressed breakpoints."), _(" \ > top.c:2270:Set whether GDB should start up quietly."), _(" \ > > Can you confirm and include them in your patch? Confirmed and installed as below. Thanks. commit 6a2dbb742dc5aa18bc7995f7af55fb6e74c3ae4a Author: Eli Zaretskii AuthorDate: Tue Apr 16 19:13:39 2024 +0300 Commit: Eli Zaretskii CommitDate: Tue Apr 16 19:13:39 2024 +0300 Remove excess whitespace from doc strings of some commands I've noticed that doc strings of some commands, like "set cwd" and "set inferior-tty", have some excess whitespace, which makes them display with unexpected indentation, at least in a Windows command prompt window. This patch fixes that. * gdb/linux-nat.c (_initialize_linux_nat): * gdb/riscv-tdep.c (riscv_insn): * gdb/top.c (quit_force): * gdb/infcmd.c (_initialize_infcmd): Remove excess whitespace. diff --git a/gdb/infcmd.c b/gdb/infcmd.c index 600c90c..10a964a 100644 --- a/gdb/infcmd.c +++ b/gdb/infcmd.c @@ -3093,10 +3093,10 @@ _initialize_infcmd () /* Add the filename of the terminal connected to inferior I/O. */ auto tty_set_show = add_setshow_optional_filename_cmd ("inferior-tty", class_run, _("\ -Set terminal for future runs of program being debugged."), _(" \ -Show terminal for future runs of program being debugged."), _(" \ -Usage: set inferior-tty [TTY]\n\n \ -If TTY is omitted, the default behavior of using the same terminal as GDB\n \ +Set terminal for future runs of program being debugged."), _("\ +Show terminal for future runs of program being debugged."), _("\ +Usage: set inferior-tty [TTY]\n\n\ +If TTY is omitted, the default behavior of using the same terminal as GDB\n\ is restored."), set_tty_value, get_tty_value, @@ -3117,8 +3117,8 @@ Follow this command with any number of args, to be passed to the program."), auto cwd_set_show = add_setshow_string_noescape_cmd ("cwd", class_run, _("\ -Set the current working directory to be used when the inferior is started.\n \ -Changing this setting does not have any effect on inferiors that are\n \ +Set the current working directory to be used when the inferior is started.\n\ +Changing this setting does not have any effect on inferiors that are\n\ already running."), _("\ Show the current working directory that is used when the inferior is started."), diff --git a/gdb/linux-nat.c b/gdb/linux-nat.c index 2602e1f..42051f2 100644 --- a/gdb/linux-nat.c +++ b/gdb/linux-nat.c @@ -4701,8 +4701,8 @@ _initialize_linux_nat () { add_setshow_boolean_cmd ("linux-nat", class_maintenance, &debug_linux_nat, _("\ -Set debugging of GNU/Linux native target."), _(" \ -Show debugging of GNU/Linux native target."), _(" \ +Set debugging of GNU/Linux native target."), _("\ +Show debugging of GNU/Linux native target."), _("\ When on, print debug messages relating to the GNU/Linux native target."), nullptr, show_debug_linux_nat, diff --git a/gdb/riscv-tdep.c b/gdb/riscv-tdep.c index f86a379..fe4da1a 100644 --- a/gdb/riscv-tdep.c +++ b/gdb/riscv-tdep.c @@ -4821,7 +4821,7 @@ initialisation process."), add_setshow_auto_boolean_cmd ("use-compressed-breakpoints", no_class, &use_compressed_breakpoints, _("\ -Set debugger's use of compressed breakpoints."), _(" \ +Set debugger's use of compressed breakpoints."), _("\ Show debugger's use of compressed breakpoints."), _("\ Debugging compressed code requires compressed breakpoints to be used. If\n\ left to 'auto' then gdb will use them if the existing instruction is a\n\ diff --git a/gdb/top.c b/gdb/top.c index 6e9df41..d01a0c2 100644 --- a/gdb/top.c +++ b/gdb/top.c @@ -2267,7 +2267,7 @@ input settings."), add_setshow_boolean_cmd ("startup-quietly", class_support, &startup_quiet, _("\ -Set whether GDB should start up quietly."), _(" \ +Set whether GDB should start up quietly."), _("\ Show whether GDB should start up quietly."), _("\ This setting will not affect the current session. Instead this command\n\ should be added to the .gdbearlyinit file in the users home directory to\n\