From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 1EC8B3858D32 for ; Mon, 15 Apr 2024 10:59:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1EC8B3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1EC8B3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713178777; cv=none; b=ThXXbrxCpou2MI6usIsfT0MUHLJ/kNeptmZDG50LcxdjCUrs1eVTydNYnZ9KkxEF3a/6rsfuDRiQDflWeNbMXaSqbNj3SINplPW3xu9VnxFJaHcBGNvMm/y6tc5ffHihxFEhzaJO+etyHjKNZS5p+OL01s2Gnr/deA/Xo80O4V4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713178777; c=relaxed/simple; bh=Lk8B8qdw+UZlzzCD62ddsSrlZZTgrlVQrBYlkP8/xFc=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=owr+gbV5xi4A2uTwonMi603Cpmvg+mbWUH0Y0v/3JtVMDQZPZv2YnFa/l2x6GeKCzAXq6Vb5F0w4cY/1X9JyMvQh8qIagnNerky1JhB4FXuVwDHXPlyVK3SC0nZbP7Z5cdPwwIclFbsTiL5T96Nm51Hd8jUuK/Py5ib57eSeDwM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rwK3h-0004WH-VW; Mon, 15 Apr 2024 06:59:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XJBkmPdPSTsZuPZWg4ErbThPnmZNCQVs57gyzbd6wV4=; b=DpwzViB09Gz1 dYB3gaqhnB/r9tAIC671F+yURYKW8KNg6tRN+VuF3VhffAW58itYBz04vl7syjzKl2u/9ICqHgkvg mbsK9m9De5W9Ht4IUXXQC7zPif8RtRWsRsC1AJpjVchYUc+vE8YwtSQS/091mAe5SPqs0bmcCKHiX PKOH1hJ6Cs4cn+aLhBoM6vlQNZH5PD/cpzEAyoYVPm3LIvByH97oj5WvoM7GmyAADt9ZfrzQ0nTZJ jtfuLZ1APT0vVZHLyACYG7d4xuxTTZz5igFx+hk0BueVqwDsjHyq1h18T0ozX8sUkUz4N7ARY6Ecm VkD+21Gnb9sNPYuCeSbh/w==; Date: Mon, 15 Apr 2024 13:59:14 +0300 Message-Id: <86v84ilwn1.fsf@gnu.org> From: Eli Zaretskii To: Alex Chronopoulos Cc: gdb-patches@sourceware.org In-Reply-To: <20240414193653.3289837-1-achronop@gmail.com> (message from Alex Chronopoulos on Sun, 14 Apr 2024 21:36:53 +0200) Subject: Re: [PATCH v3] Change message when reaching end of reverse history. References: <20240414193653.3289837-1-achronop@gmail.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Alex Chronopoulos > Cc: Alex Chronopoulos > Date: Sun, 14 Apr 2024 21:36:53 +0200 > > In a record session, when we move backward, GDB switches from normal > execution to simulation. Moving forward again, the emulation continues > until the end of the reverse history. When the end is reached, the > execution stops, and a warning message is shown. This message has been > modified to indicate that the forward emulation has reached the end, but > the execution can continue as normal, and the recording will also continue. > > Before this patch, the warning message shown in that case was the same as > in the reverse case. This meant that when the end of history was reached in > either backward or forward emulation, the same message was displayed: > > "No more reverse-execution history." > > This message remains for backward emulation. However, in forward emulation, > it has been modified to: > > "End of recorded history; following steps will be added to history." > > The reason for this change is that the initial message was deceiving, for > the forward case, making the user believe that forward debugging could not > continue. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31224 > --- > gdb/NEWS | 5 ++++ > gdb/infrun.c | 8 ++++- > gdb/testsuite/gdb.btrace/non-stop.exp | 30 ++++++++++++------- > gdb/testsuite/gdb.reverse/break-precsave.exp | 4 +-- > gdb/testsuite/gdb.reverse/break-reverse.exp | 2 +- > .../gdb.reverse/machinestate-precsave.exp | 2 +- > 6 files changed, 36 insertions(+), 15 deletions(-) Thanks, the NEWS part is approved. Reviewed-By: Eli Zaretskii