From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 9845E3858CD1 for ; Thu, 21 Mar 2024 16:48:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9845E3858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9845E3858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711039726; cv=none; b=Qnkb4ZYQgIdPGvWzxBBl8J+ZKxnz3JSxiSNSW+pd+s76WM6KCleuP2wmiWZOnFd6qk6DYm2L2jApDZZFVUxau0khf64TGRAz7N+XA7Laym5sQDSm224f+8Vk+KmBTDwjzb2YLWAPkBeGrDoVL1j48Bi84U7lhTL7MrNOxcbQj2U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711039726; c=relaxed/simple; bh=9rF7CTCZjQOQ2DIV5Lyl8DRnYoOVZtfq4V9sxJ8LzFU=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=MBzmRr46PQWUkwryL41lhGVuaD0xNiHMK5uo6m8VC0ttVPUzY/1rqRcwyln6Mn7fme9Oz4WPUWX63u1qskfgZqvkYpIm5dW26/sdJscyyVP8PAps2oAD7y05VFgPwpPTmdlrjsR8gkyyuPlanZMTSo/GWU8YO75PLufWpd/Fyj8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rnLau-000098-5G; Thu, 21 Mar 2024 12:48:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=kI7fBhH5KRjU7ZzyBgL+kehocaqwmSuAWzQYUoe7uMo=; b=DpZgFlCXvywA WCzEYySTcQ3pELwsqUS+uJKqSzBBzLkIXt1UusiA2XeymN/Q8umdihnwEieVLp4MGXUhLADvh8PPj wlL3zsjVFd+DGuWuA+rUTMzSpiFBrK/3O5iUKbB4oyF3PSscQG/SjqVSu4ebTNzi2/NfmyeiysWJ5 e/0vM5ZGma1/Q1aZBUZDNu+bnkpNWxG2NlGAfukW2fxLZkW6B8YBTIr1Ehu63bA13bZsFkop/HVke h6Ylzm1xVgyLW1kS6gPuh2nEFVemjmuI2cWYGdL2xzugitAcYuV8oBg7MxGRMaJ+gxq5pAWof57js ebox+81qdRL0mtr1z+kotw==; Date: Thu, 21 Mar 2024 18:48:39 +0200 Message-Id: <86v85f1qfs.fsf@gnu.org> From: Eli Zaretskii To: Tankut Baris Aktemur Cc: gdb-patches@sourceware.org In-Reply-To: <20240321133018.602537-1-tankut.baris.aktemur@intel.com> (message from Tankut Baris Aktemur on Thu, 21 Mar 2024 14:30:18 +0100) Subject: Re: [RFC PATCH] gdb, rsp: clarify a 0-length memory access References: <20240321133018.602537-1-tankut.baris.aktemur@intel.com> X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Tankut Baris Aktemur > Date: Thu, 21 Mar 2024 14:30:18 +0100 > > Currently GDB uses a 0-length write access to probe for the 'X' packet > support. However, it is not clear from the document what a 0-length > read or write attempt should do. Clarify the document that it is > an error. Also update gdbserver's implementation to return an error. > > Note that for probing, returning an error is fine. It successfully > shows that the packet is supported. > > Regression-tested on X86-64 Linux using the default (unix) and > native-extended-gdbserver board files. > --- > gdb/doc/gdb.texinfo | 9 +++++++++ > gdbserver/target.cc | 9 ++++++--- > 2 files changed, 15 insertions(+), 3 deletions(-) Thanks, the documentation part is okay. Reviewed-By: Eli Zaretskii