* [PATCH] Remove one line comment
@ 2017-06-27 7:57 Yao Qi
2017-07-18 12:01 ` Yao Qi
0 siblings, 1 reply; 2+ messages in thread
From: Yao Qi @ 2017-06-27 7:57 UTC (permalink / raw)
To: gdb-patches
This patch is going to remove a line comment, which was added in this
commit,
commit 55fea07
Author: Jim Kingdon <jkingdon@engr.sgi.com>
Date: Tue Sep 14 01:08:22 1993 +0000
* remote.c: Define remote_debug to 0 and #if 0 baud_rate. Temporary
hack so this file compiles again.
* remote-utils.c (gr_multi_scan): Cast return value from alloca.
(gr_multi_scan): #if 0 never-reached return(-1).
and at that moment, remote_prepare_to_store does updates some global
state,
static void
remote_prepare_to_store ()
{
/* Make sure the entire registers array is valid. */
read_register_bytes (0, (char *)NULL, REGISTER_BYTES);
}
However, now, remote_prepare_to_store doesn't do that at all, and
rsa->sizeof_g_packet is updated in init_remote_state, so the line of
comment is out of date, and this patch removes it.
gdb:
2017-06-27 Yao Qi <yao.qi@linaro.org>
* remote.c (store_registers_using_G): Remove one line comment.
---
gdb/remote.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/gdb/remote.c b/gdb/remote.c
index 8e8ee6f..d363a36 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -7844,8 +7844,6 @@ store_registers_using_G (const struct regcache *regcache)
each byte encoded as two hex characters. */
p = rs->buf;
*p++ = 'G';
- /* remote_prepare_to_store insures that rsa->sizeof_g_packet gets
- updated. */
bin2hex (regs, p, rsa->sizeof_g_packet);
putpkt (rs->buf);
getpkt (&rs->buf, &rs->buf_size, 0);
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove one line comment
2017-06-27 7:57 [PATCH] Remove one line comment Yao Qi
@ 2017-07-18 12:01 ` Yao Qi
0 siblings, 0 replies; 2+ messages in thread
From: Yao Qi @ 2017-07-18 12:01 UTC (permalink / raw)
To: gdb-patches
Yao Qi <qiyaoltc@gmail.com> writes:
> gdb:
>
> 2017-06-27 Yao Qi <yao.qi@linaro.org>
>
> * remote.c (store_registers_using_G): Remove one line comment.
I pushed it in.
--
Yao (齐尧)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-07-18 12:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-27 7:57 [PATCH] Remove one line comment Yao Qi
2017-07-18 12:01 ` Yao Qi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).