From: Yao Qi <qiyaoltc@gmail.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb: Make some test names unique
Date: Thu, 22 Jun 2017 10:37:00 -0000 [thread overview]
Message-ID: <86vanoi9zm.fsf@gmail.com> (raw)
In-Reply-To: <c9b6ef063fbb5e33c157b1041418cd2fb7d8cf27.1497466455.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Wed, 14 Jun 2017 19:57:39 +0100")
Andrew Burgess <andrew.burgess@embecosm.com> writes:
> mi_gdb_test "540-data-evaluate-expression vla1(1)" \
> - "540\\^done,value=\"1\"" "evaluate filled vla"
> + "540\\^done,value=\"1\"" "evaluate filled vla(1)"
Do not use "tail parentheses" on the test message,
https://sourceware.org/gdb/wiki/GDBTestcaseCookbook#Do_not_use_.22tail_parentheses.22_on_test_messages
Maybe ""evaluate filled vla1 1"?
> mi_gdb_test "550-data-evaluate-expression vla1(2)" \
> - "550\\^done,value=\"42\"" "evaluate filled vla"
> + "550\\^done,value=\"42\"" "evaluate filled vla(2)"
> mi_gdb_test "560-data-evaluate-expression vla1(4)" \
> - "560\\^done,value=\"24\"" "evaluate filled vla"
> + "560\\^done,value=\"24\"" "evaluate filled vla(4)"
Otherwise, patch is good to me.
--
Yao (齐尧)
next prev parent reply other threads:[~2017-06-22 10:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 18:57 [PATCH 0/2] Couple of small fixes to gdb.mi/mi-vla-fortran.exp test Andrew Burgess
2017-06-14 18:58 ` [PATCH 1/2] gdb: Fix parameter passing to mi_create_breakpoint Andrew Burgess
2017-06-22 10:16 ` Yao Qi
2017-06-14 18:58 ` [PATCH 2/2] gdb: Make some test names unique Andrew Burgess
2017-06-22 10:37 ` Yao Qi [this message]
2017-06-22 11:08 ` Pedro Alves
2017-06-22 11:59 ` Yao Qi
2017-06-22 12:06 ` Pedro Alves
2017-06-22 12:12 ` Pedro Alves
2017-07-13 20:15 ` [PATCHv2 " Andrew Burgess
2017-07-13 22:40 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86vanoi9zm.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).