Re: [PATCH V2 1/3] fort_dyn_array: Enable dynamic member types inside a structure.

[Yao Qi <qiyaoltc@gmail.com>]

Bernhard Heckel <bernhard.heckel@intel.com> writes:

Hi Bernhard,
Patch is good to me, two nits below,

> +  /* If type has a dynamic resolved location property update it's value address.  */

This line is too long.

> +  type = value_type (whole);
> +  if (TYPE_DATA_LOCATION (type)
> +      && TYPE_DATA_LOCATION_KIND (type) == PROP_CONST)
> +    set_value_address (component, TYPE_DATA_LOCATION_ADDR (type));
>  }
>  
> -\f
>  /* Access to the value history.  */
>  
>  /* Record a new value in the value history.
> @@ -2416,6 +2428,12 @@ set_internalvar (struct internalvar *var, struct value *val)
>  	 call error () until new_data is installed into the var->u to avoid
>  	 leaking memory.  */
>        release_value (new_data.value);
> +
> +      /* Internal variables which are created from values with a dynamic location

This line is too long.

> +         don't need the location property of the origin anymore.
> +         Remove the location property in case it exist.  */
> +      remove_dyn_prop (DYN_PROP_DATA_LOCATION, value_type (new_data.value));

-- 
Yao (齐尧)