From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24962 invoked by alias); 8 Apr 2015 09:28:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 24947 invoked by uid 89); 8 Apr 2015 09:28:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.4 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f45.google.com Received: from mail-pa0-f45.google.com (HELO mail-pa0-f45.google.com) (209.85.220.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 08 Apr 2015 09:28:15 +0000 Received: by paboj16 with SMTP id oj16so109270738pab.0 for ; Wed, 08 Apr 2015 02:28:14 -0700 (PDT) X-Received: by 10.68.68.240 with SMTP id z16mr20256851pbt.31.1428485294221; Wed, 08 Apr 2015 02:28:14 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id f12sm10790120pat.43.2015.04.08.02.28.12 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 08 Apr 2015 02:28:13 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 06/23] Make thread_still_needs_step_over consider stepping_over_watchpoint too References: <1428410990-28560-1-git-send-email-palves@redhat.com> <1428410990-28560-7-git-send-email-palves@redhat.com> Date: Wed, 08 Apr 2015 09:28:00 -0000 In-Reply-To: <1428410990-28560-7-git-send-email-palves@redhat.com> (Pedro Alves's message of "Tue, 7 Apr 2015 13:49:33 +0100") Message-ID: <86vbh7vuja.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00254.txt.bz2 Pedro Alves writes: > +static int > +thread_still_needs_step_over (struct thread_info *tp) > +{ > + struct inferior *inf =3D find_inferior_ptid (tp->ptid); 'inf' isn't used. > @@ -6327,6 +6357,8 @@ keep_going (struct execution_control_state *ecs) > else > clear_step_over_info (); >=20=20 > + ecs->event_thread->control.trap_expected =3D (remove_bp || remove_= wps); > + > /* Stop stepping if inserting breakpoints fails. */ > TRY > { > @@ -6341,8 +6373,6 @@ keep_going (struct execution_control_state *ecs) > } > END_CATCH >=20=20 > - ecs->event_thread->control.trap_expected =3D (remove_bp || remove_= wps); > - Why do we hoist this line in front of the TRY/CATCH block? because we want to set control.trap_expected before insert_breakpoints which may throw exception? We need a ChangeLog entry for it. --=20 Yao (=E9=BD=90=E5=B0=A7)