From: Yao Qi <qiyaoltc@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: simon.marchi@ericsson.com, gdb-patches@sourceware.org
Subject: Re: [ANNOUNCEMENT] GDB 8.1 release branch created!
Date: Thu, 01 Feb 2018 15:12:00 -0000 [thread overview]
Message-ID: <86wozwbv68.fsf@gmail.com> (raw)
In-Reply-To: <83607njlsh.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 27 Jan 2018 18:42:22 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
> No further comments, so I went ahead and pushed the change, without
> the __cplusplus part, to master, and then cherry-picked to
> gdb-8.1-branch.
Hi Eli,
Is it intended to include error messages in the changelog entry? If
not, can we remove it? in the patch below,
2018-01-27 Eli Zaretskii <eliz@gnu.org>
Avoid compilation errors in MinGW native builds
The error is triggered by including python-internal.h, and the
error message is:
In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
from build-gnulib/import/math.h:27,
from d:/usr/Python26/include/pyport.h:235,
from d:/usr/Python26/include/Python.h:58,
from python/python-internal.h:94,
from python/py-arch.c:24:
d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
using ::hypot;
^~~~~
This happens because Python headers define 'hypot' to expand t
'_hypot' in the Windows builds.
* python/python-internal.h (_hypot) [__MINGW32__]: Define back to
'hypoth'. This avoids a compilation error.
--
Yao (齐尧)
From 65951173ddd802b5c26f3f706ad845f41dc78f8b Mon Sep 17 00:00:00 2001
From: Yao Qi <yao.qi@linaro.org>
Date: Thu, 1 Feb 2018 15:11:46 +0000
Subject: [PATCH] Remove unnecessary bits from ChangeLog
Remove something shouldn't be put in ChangeLog.
diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5c3338f..40f4008 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -144,23 +144,6 @@
2018-01-27 Eli Zaretskii <eliz@gnu.org>
- Avoid compilation errors in MinGW native builds
-
- The error is triggered by including python-internal.h, and the
- error message is:
-
- In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0,
- from build-gnulib/import/math.h:27,
- from d:/usr/Python26/include/pyport.h:235,
- from d:/usr/Python26/include/Python.h:58,
- from python/python-internal.h:94,
- from python/py-arch.c:24:
- d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared
- using ::hypot;
- ^~~~~
-
- This happens because Python headers define 'hypot' to expand t
- '_hypot' in the Windows builds.
* python/python-internal.h (_hypot) [__MINGW32__]: Define back to
'hypoth'. This avoids a compilation error.
next prev parent reply other threads:[~2018-02-01 15:12 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <announce.20180105041805.3FC35808E9@joel.gnat.com>
2018-01-16 17:31 ` Eli Zaretskii
2018-01-16 19:02 ` Sergio Durigan Junior
2018-01-16 19:46 ` [PATCH] Fix warning on gdb/compile/compile.c (C++-ify "triplet_rx") Sergio Durigan Junior
2018-01-17 15:33 ` Eli Zaretskii
2018-01-17 17:17 ` Simon Marchi
2018-01-17 23:07 ` Sergio Durigan Junior
2018-01-17 23:42 ` Simon Marchi
2018-01-17 23:48 ` Sergio Durigan Junior
2018-01-16 20:32 ` [PATCH] Fix unitialized warning on gdb/typeprint.c:whatis_exp Sergio Durigan Junior
2018-01-17 15:34 ` Eli Zaretskii
2018-01-17 16:48 ` Pedro Alves
2018-01-17 18:03 ` Sergio Durigan Junior
2018-01-20 1:03 ` [PATCH] Fix segfault when using 'set print object on' + whatis <struct> Sergio Durigan Junior
2018-01-22 17:42 ` [PATCH v2] Fix segfault when using 'set print object on' + whatis <struct> (Re: [PATCH] Fix segfault when using 'set print object on' + whatis <struct>) Pedro Alves
2018-01-22 18:04 ` Sergio Durigan Junior
2018-01-22 19:53 ` Pedro Alves
2018-01-22 20:11 ` Sergio Durigan Junior
2018-01-16 20:36 ` [ANNOUNCEMENT] GDB 8.1 release branch created! Sergio Durigan Junior
2018-01-17 3:36 ` Eli Zaretskii
2018-01-17 16:46 ` Sergio Durigan Junior
2018-01-17 11:04 ` Pedro Alves
2018-01-17 16:38 ` Sergio Durigan Junior
2018-01-17 16:46 ` Eli Zaretskii
2018-01-17 16:50 ` Pedro Alves
2018-01-17 18:21 ` Eli Zaretskii
2018-01-18 15:53 ` Eli Zaretskii
2018-01-25 16:58 ` Eli Zaretskii
2018-01-26 14:18 ` Eli Zaretskii
2018-01-26 15:37 ` Simon Marchi
2018-01-26 18:53 ` Eli Zaretskii
2018-01-27 16:42 ` Eli Zaretskii
2018-02-01 15:12 ` Yao Qi [this message]
2018-02-01 16:27 ` Eli Zaretskii
2018-02-01 16:51 ` Yao Qi
2018-02-01 17:33 ` Eli Zaretskii
2018-02-01 21:32 ` Yao Qi
2018-02-02 15:23 ` Eli Zaretskii
2018-02-02 15:53 ` Joel Brobecker
2018-02-02 16:27 ` Simon Marchi
2018-02-02 17:42 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86wozwbv68.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).