public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Find arm-linux-gnueabihf-gcc in compile
Date: Fri, 19 Jan 2018 09:12:00 -0000	[thread overview]
Message-ID: <86y3kudxfm.fsf@gmail.com> (raw)
In-Reply-To: <c42c3c67-4076-fe46-c739-1cd0d1c37246@redhat.com> (Pedro Alves's	message of "Thu, 18 Jan 2018 18:32:05 +0000")

Pedro Alves <palves@redhat.com> writes:

> Debian seems to have a "arm-linux-gnueabi-gcc" as well,
> <https://packages.debian.org/sid/gcc-7-arm-linux-gnueabi>, 
> which I assume is a version that defaults to soft-float.  (Or
> is that softfp?)

Yes, arm-linux-gnueabi implies the EABI with -mfloat-abi=soft or
-mfloat-abi=softfp, while arm-linux-gnueabihf implies -mfloat-abi=hard.
I amend the commitlog a little, and push the patch below in.

-- 
Yao (齐尧)
From dea445b940545f9564972c5410ac8792b72cc9c3 Mon Sep 17 00:00:00 2001
From: Yao Qi <yao.qi@linaro.org>
Date: Fri, 19 Jan 2018 09:08:36 +0000
Subject: [PATCH] Find arm-linux-gnueabi(hf)?-gcc in compile

GCC for arm-linux has different names on different distros.  It is
arm-linux-gnu-gcc on fedora.  Debian/Ubuntu has arm-linux-gnueabihf-gcc
and arm-linux-gnueabi-gcc.  So when I run gdb.compile/ tests on arm-linux,
I get,

(gdb) compile code -- ;
Could not find a compiler matching "^arm(-[^-]*)?-linux(-gnu)?-gcc$"

This patch extend the regexp to match both arm-linux-gnu-gcc and
arm-linux-gnueabihf-gcc.

gdb:

2018-01-19  Yao Qi  <yao.qi@linaro.org>

	* osabi.c (gdb_osabi_names): Extend the regexp for
	arm-linux-gnueabihf and arm-linux-gnueabi.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 90dacd2..6709f44 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2018-01-19  Yao Qi  <yao.qi@linaro.org>
+
+	* osabi.c (gdb_osabi_names): Extend the regexp for
+	arm-linux-gnueabihf.
+
 2018-01-18  Yao Qi  <yao.qi@linaro.org>
 
 	* dwarf2read.c (abbrev_table) <abbrevs>: Rename it to
diff --git a/gdb/osabi.c b/gdb/osabi.c
index 129164f..fd44deb 100644
--- a/gdb/osabi.c
+++ b/gdb/osabi.c
@@ -63,7 +63,7 @@ static const struct osabi_names gdb_osabi_names[] =
   { "SVR4", NULL },
   { "GNU/Hurd", NULL },
   { "Solaris", NULL },
-  { "GNU/Linux", "linux(-gnu)?" },
+  { "GNU/Linux", "linux(-gnu[^-]*)?" },
   { "FreeBSD", NULL },
   { "NetBSD", NULL },
   { "OpenBSD", NULL },

      reply	other threads:[~2018-01-19  9:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-18  8:46 Yao Qi
2018-01-18 15:35 ` Simon Marchi
2018-01-18 18:32 ` Pedro Alves
2018-01-19  9:12   ` Yao Qi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86y3kudxfm.fsf@gmail.com \
    --to=qiyaoltc@gmail.com \
    --cc=gdb-patches@sourceware.org \
    --cc=palves@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).