From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20891 invoked by alias); 4 Oct 2017 10:39:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20873 invoked by uid 89); 4 Oct 2017 10:39:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=Hx-languages-length:1997, H*r:sk:static. X-HELO: mail-wr0-f182.google.com Received: from mail-wr0-f182.google.com (HELO mail-wr0-f182.google.com) (209.85.128.182) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 04 Oct 2017 10:39:00 +0000 Received: by mail-wr0-f182.google.com with SMTP id j14so8367050wre.8 for ; Wed, 04 Oct 2017 03:38:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=jIcJPu0tsdh3HcjcqO3Z0cCua0G5q3E6efnX6KN3ShA=; b=YCsto3oxg2KGBofL8bo5SUKqivL3XvnAbGcgDKmUdLxwH8Vp09znx3rp8KBfWfRNMN qYJU+lz43t2fvHedXQwjosDQuSFAN2QtinRL9Byho4LPBkjJpDB8Y7ap/u0wq3YqxdQX g+M57eLzyhaBnoFKVG6QMZ7OAxwjTbO4ExDhUakXVHUM0O9RsvIhGC/Kyg+LyolIqCFn 4d23i9owErPUeaXto0lnZwxD3cnCuuvsEz4GZNnqML2kq6kdAuvRfvM6/HnAzSvCAxmX U4DEtyObAio0ofaRMZS7luNRFpMfYVihERDtiu/NLpxq0bbPRbTdKzSu5upzCdcjXNWL GaVw== X-Gm-Message-State: AHPjjUgdx3bPUGNjgQ09cziBLuoV9EnvSmtR9MRycbKtYyXprHW2jMP2 UkTy9WuxpKRmWzkmbYoMm0xaew== X-Google-Smtp-Source: AOwi7QB5IFgwLntrmYUO+stnfzO/WaY61GVRhfJaLU5iUt9CACQrKhcP2sMskOz3gB9Bemvivz98IQ== X-Received: by 10.223.162.199 with SMTP id t7mr22094120wra.151.1507113537888; Wed, 04 Oct 2017 03:38:57 -0700 (PDT) Received: from E107787-LIN (static.42.136.251.148.clients.your-server.de. [148.251.136.42]) by smtp.gmail.com with ESMTPSA id 33sm1322075wrs.28.2017.10.04.03.38.56 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 04 Oct 2017 03:38:57 -0700 (PDT) From: Yao Qi To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Redesign mock environment for gdbarch selftests References: <1506957311-30028-1-git-send-email-palves@redhat.com> <1506957311-30028-2-git-send-email-palves@redhat.com> <86k20c7aob.fsf@gmail.com> Date: Wed, 04 Oct 2017 10:39:00 -0000 In-Reply-To: (Pedro Alves's message of "Tue, 3 Oct 2017 13:05:38 +0100") Message-ID: <86y3or5ha8.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00078.txt.bz2 Pedro Alves writes: > OK. I propose we stick with something like I had, and still build > an isolated inferior/aspace etc. To me, that feels like more robust I like the way that we can build an isolated inferior/aspace for unit test. > mocking/isolation. If I run the tests while debugging something > with the updated patch (below), I get: > > (gdb) maint selftest=20 > Running selftest array_view. > Running selftest copy_bitwise. > Running selftest copy_integer_to_size. > Running selftest current_regcache. > Running selftest execute_cfa_program. > Running selftest function_view. > Running selftest gdb_environ. > Running selftest gdb_realpath. > Running selftest memory_error. > Running selftest offset_type. > Running selftest optional. > Running selftest print_one_insn. > Running selftest producer-parser. > Running selftest register_to_value. > Self test failed: arch i386: target already pushed > Self test failed: arch i386:x86-64: target already pushed > Self test failed: arch i386:x64-32: target already pushed > Self test failed: arch i8086: target already pushed > Self test failed: arch i386:intel: target already pushed > Self test failed: arch i386:x86-64:intel: target already pushed > Self test failed: arch i386:x64-32:intel: target already pushed > Self test failed: arch i386:nacl: target already pushed > Self test failed: arch i386:x86-64:nacl: target already pushed > Self test failed: arch i386:x64-32:nacl: target already pushed > Self test failed: self-test failed at > /home/pedro/gdb/mygit/src/gdb/selftest-arch.c:86 > Running selftest rust-lex. > Running selftest scoped_restore. > Running selftest string_printf. > Running selftest string_vprintf. > Running selftest xml_escape_text. > Ran 19 unit tests, 1 failed > > So it ends up being best effort, with most things passing and > the gdbarch test failing. > > WDYT? That is fine by me. Patch is good to me. --=20 Yao (=E9=BD=90=E5=B0=A7)