From: Yao Qi <qiyaoltc@gmail.com>
To: Alan Hayward <Alan.Hayward@arm.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>,
nd <nd@arm.com>
Subject: Re: [PATCH 10/11] Add XTENSA_MAX_REGISTER_SIZE
Date: Wed, 05 Apr 2017 10:23:00 -0000 [thread overview]
Message-ID: <86y3vfp308.fsf@gmail.com> (raw)
In-Reply-To: <A9D0B291-CF87-44EB-9B48-E1E66B7578D9@arm.com> (Alan Hayward's message of "Tue, 4 Apr 2017 10:15:57 +0000")
Alan Hayward <Alan.Hayward@arm.com> writes:
> @@ -559,7 +559,7 @@ xtensa_pseudo_register_read (struct gdbarch *gdbarch,
> && (regnum >= gdbarch_tdep (gdbarch)->a0_base)
> && (regnum <= gdbarch_tdep (gdbarch)->a0_base + 15))
> {
> - gdb_byte *buf = (gdb_byte *) alloca (MAX_REGISTER_SIZE);
> + gdb_byte *buf = (gdb_byte *) alloca (XTENSA_MAX_REGISTER_SIZE);
> enum register_status status;
>
> status = regcache_raw_read (regcache,
> @@ -655,7 +655,7 @@ xtensa_pseudo_register_write (struct gdbarch *gdbarch,
> && (regnum >= gdbarch_tdep (gdbarch)->a0_base)
> && (regnum <= gdbarch_tdep (gdbarch)->a0_base + 15))
> {
> - gdb_byte *buf = (gdb_byte *) alloca (MAX_REGISTER_SIZE);
> + gdb_byte *buf = (gdb_byte *) alloca (XTENSA_MAX_REGISTER_SIZE);
>
> regcache_raw_read (regcache,
> gdbarch_tdep (gdbarch)->wb_regnum, buf);
The "buf" can be removed by using regcache_raw_read_unsigned.
--
Yao (齐尧)
next prev parent reply other threads:[~2017-04-05 10:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 10:16 Alan Hayward
2017-04-05 10:23 ` Yao Qi [this message]
2017-04-06 12:49 ` Alan Hayward
2017-04-25 15:39 ` Yao Qi
2017-04-26 9:59 ` Alan Hayward
2017-06-08 9:42 ` Alan Hayward
2017-06-12 9:54 ` Yao Qi
2017-06-21 9:36 ` Alan Hayward
2017-06-22 16:40 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86y3vfp308.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=Alan.Hayward@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).