From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 4/7] Insert breakpoint even when the raw breakpoint is found
Date: Tue, 12 Apr 2016 09:04:00 -0000 [thread overview]
Message-ID: <86y48jjj0v.fsf@gmail.com> (raw)
In-Reply-To: <570BB7AF.1080703@redhat.com> (Pedro Alves's message of "Mon, 11 Apr 2016 15:41:51 +0100")
Pedro Alves <palves@redhat.com> writes:
> Can we only increase the refcount if inserting succeeds? gdbserver can
> use gdb exceptions nowadays, and even though lots of current gdbserver
> code isn't exception safe, it'd be nice to start considering that.
One thing I can think of is to properly decrease refcount if exception
is thrown. Anything else? I don't think we need to worry about the
atomicity of increment and decrement of refcount, because I don't figure
out a case the refcount is updated together in mainline code and in
exception.
--
Yao (齐尧)
next prev parent reply other threads:[~2016-04-12 9:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 16:10 [PATCH 0/7 V2] Step over instruction branches to itself Yao Qi
2016-03-23 16:10 ` [PATCH 1/7] New test case gdb.trace/signal.exp Yao Qi
2016-04-08 16:52 ` Pedro Alves
2016-04-11 8:41 ` Yao Qi
2016-04-11 14:04 ` Pedro Alves
2016-04-22 10:53 ` Yao Qi
2016-04-26 12:57 ` Pedro Alves
2016-04-11 14:08 ` Pedro Alves
2016-03-23 16:10 ` [PATCH 5/7] [GDBserver] Don't error in reinsert_raw_breakpoint if bp->inserted Yao Qi
2016-04-11 14:54 ` Pedro Alves
2016-03-23 16:10 ` [PATCH 3/7] Force to insert software single step breakpoint Yao Qi
2016-04-11 14:31 ` Pedro Alves
2016-04-13 16:21 ` Yao Qi
2016-04-19 14:54 ` Yao Qi
2016-04-19 15:17 ` Pedro Alves
2016-04-20 7:50 ` Yao Qi
2016-04-22 16:36 ` Pedro Alves
2016-04-25 8:40 ` Yao Qi
2016-03-23 16:10 ` [PATCH 4/7] Insert breakpoint even when the raw breakpoint is found Yao Qi
2016-04-11 14:41 ` Pedro Alves
2016-04-12 9:04 ` Yao Qi [this message]
2016-04-12 9:41 ` Pedro Alves
2016-04-25 8:45 ` Yao Qi
2016-03-23 16:10 ` [PATCH 6/7] Resume the inferior with signal rather than stepping over Yao Qi
2016-04-11 15:29 ` Pedro Alves
2016-03-23 16:10 ` [PATCH 2/7] Deliver signal in hardware single step Yao Qi
2016-04-11 14:10 ` Pedro Alves
2016-04-22 10:54 ` Yao Qi
2016-03-23 16:26 ` [PATCH 7/7] New test case gdb.base/branch-to-self.exp Yao Qi
2016-04-11 15:34 ` Pedro Alves
2016-04-25 8:58 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86y48jjj0v.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).