From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120211 invoked by alias); 16 Sep 2015 09:15:20 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 116845 invoked by uid 89); 16 Sep 2015 09:15:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f172.google.com Received: from mail-wi0-f172.google.com (HELO mail-wi0-f172.google.com) (209.85.212.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 16 Sep 2015 09:15:15 +0000 Received: by wicfx3 with SMTP id fx3so61031787wic.0 for ; Wed, 16 Sep 2015 02:15:12 -0700 (PDT) X-Received: by 10.195.13.5 with SMTP id eu5mr19684672wjd.135.1442394912709; Wed, 16 Sep 2015 02:15:12 -0700 (PDT) Received: from E107787-LIN ([195.154.84.196]) by smtp.gmail.com with ESMTPSA id gc8sm3435956wib.2.2015.09.16.02.15.11 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 16 Sep 2015 02:15:12 -0700 (PDT) From: Yao Qi To: Pierre Langlois Cc: gdb-patches@sourceware.org, uweigand@de.ibm.com, cole945@gmail.com Subject: Re: [PATCH 1/2] [GDBserver] Fix compiling conditional expressions accessing registers References: <1441992301-26779-1-git-send-email-pierre.langlois@arm.com> <1441992301-26779-2-git-send-email-pierre.langlois@arm.com> Date: Wed, 16 Sep 2015 09:15:00 -0000 In-Reply-To: <1441992301-26779-2-git-send-email-pierre.langlois@arm.com> (Pierre Langlois's message of "Fri, 11 Sep 2015 18:25:00 +0100") Message-ID: <86y4g6209t.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00365.txt.bz2 Pierre Langlois writes: > This patch fixes this issue by replacing `gdb_agent_get_raw_reg' with a > `gdb_agent_get_reg' function which takes the tracepoint context object > as argument instead of a raw buffer. Additionally, this patch makes > this function architecture independent by initializing the context's > regcache early and making `gdb_agent_get_reg' use `collect_register'. > As a result, the fast tracepoint context object does not need to > contain the raw register buffer. The fix looks reasonable to me as it makes no sense to keep two copies of registers. I go through this patch, and it looks good to me. This patch invalidates Wei-cheng's patch here which is already approved but not committed. If Ulirch/Wei-cheng have no objections, this patch can go in. --=20 Yao (=E9=BD=90=E5=B0=A7)