From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115639 invoked by alias); 29 May 2015 16:33:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115626 invoked by uid 89); 29 May 2015 16:33:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f42.google.com Received: from mail-pa0-f42.google.com (HELO mail-pa0-f42.google.com) (209.85.220.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 29 May 2015 16:33:09 +0000 Received: by padbw4 with SMTP id bw4so64080505pad.0 for ; Fri, 29 May 2015 09:33:07 -0700 (PDT) X-Received: by 10.70.87.195 with SMTP id ba3mr16491466pdb.154.1432917187847; Fri, 29 May 2015 09:33:07 -0700 (PDT) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id la9sm6101014pab.2.2015.05.29.09.33.05 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 29 May 2015 09:33:06 -0700 (PDT) From: Yao Qi To: Jan Kratochvil Cc: Yao Qi , Andreas Schwab , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix wrong assertions References: <87vbg1eg08.fsf@igel.home> <20150513140106.GB3023@host1.jankratochvil.net> <86bnh3pw61.fsf@gmail.com> <20150529113101.GA15460@host1.jankratochvil.net> <86382fpki0.fsf@gmail.com> <20150529141027.GA8159@host1.jankratochvil.net> Date: Fri, 29 May 2015 16:33:00 -0000 In-Reply-To: <20150529141027.GA8159@host1.jankratochvil.net> (Jan Kratochvil's message of "Fri, 29 May 2015 16:10:27 +0200") Message-ID: <86y4k7ny2q.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00722.txt.bz2 Jan Kratochvil writes: >> > I did not realize that there can be self-tail-call: >> > main(0x100) -> a(0x200) -> d(0x400) >> > main(0x100) -> a(0x280) -> a(0x200) -> d(0x400) >> > which intersects to: >> > main(0x100) -> ? -> a(0x200) -> d(0x400) >> > And so if the first chain was chosen the >> > main(0x100) -> a(0x200) -> d(0x400) >> > then the final intersection has callers+callees=3D=3Dlength. >>=20 >> What are the definitions of CALLERS, CALLEES, top and bottom? given >> this example? > > top=3DCALLERS=3Dmain(0x100), therefore 1 > bottom=3DCALLEES=3Dd(0x400), therefore 1 > > top =3D topmost, where you can go by GDB "up" commands, also called "prev= " in > struct frame_info. > > bottom =3D bottommost, where you can go by GDB "down" commands, also call= ed > "next" in struct frame_info. OK, I understand what does top/bottom mean. Since they are numeric values, what does these number mean? for example, if CALLERS is 3 and CALLEES is 2, what does the chain look like? The code change in the patch looks reasonable to me, but comments change doesn't, probably because I don't fully understand it. I'll take a deeper look next Monday. --=20 Yao (=E9=BD=90=E5=B0=A7)