Re: [PATCH 1/1] gdb: Deprecate MPX commands.

[Eli Zaretskii <eliz@gnu.org>]

> From: "Schimpe, Christina" <christina.schimpe@intel.com>
> Date: Thu,  7 Mar 2024 12:11:11 +0000
> 
> This patch deprecates the MPX commands "show/set mpx bound".
> Intel listed Intel(R) Memory Protection Extensions (MPX) as removed
> in 2019.  Following gcc v9.1, the linux kernel v5.6 and glibc v2.35,
> deprecate MPX in GDB.
> ---
>  gdb/NEWS            | 3 +++
>  gdb/doc/gdb.texinfo | 3 +++
>  gdb/i386-tdep.c     | 6 ++++--
>  3 files changed, 10 insertions(+), 2 deletions(-)

Thanks.

> diff --git a/gdb/NEWS b/gdb/NEWS
> index 2638b3e0d9c..d8ac0bb06a7 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -3,6 +3,9 @@
>  
>  *** Changes since GDB 14
>  
> +* The MPX commands "show/set mpx bound" have been deprecated, as Intel
> +  listed MPX as removed in 2019.

This part is okay.

> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -26652,6 +26652,9 @@ whose bounds are to be changed, @var{lbound} and @var{ubound} are new values
>  for lower and upper bounds respectively.
>  @end table
>  
> +Both commands are deprecated and will be removed in future versions of
> +@value{GDBN}.  MPX itself was listed as removed by Intel in 2019.

"Will be removed" or "might be removed"?  IOW, are we certain we will
definitely remove this, or do we just want to warn users that we
might?

Reviewed-By: Eli Zaretskii <eliz@gnu.org>