From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15026 invoked by alias); 16 May 2017 08:32:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14926 invoked by uid 89); 16 May 2017 08:32:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=ham version=3.3.2 spammy=transfer X-HELO: mail-pg0-f68.google.com Received: from mail-pg0-f68.google.com (HELO mail-pg0-f68.google.com) (74.125.83.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 16 May 2017 08:32:02 +0000 Received: by mail-pg0-f68.google.com with SMTP id u187so20539304pgb.1 for ; Tue, 16 May 2017 01:32:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=dCv5SHk3H04PbqjojTVugPYu0t3Jdeg0txTtVUXMhgo=; b=EuFLkTKiF7na3D5CVR9oUyL3ZAjk8xwQHn5pPumjLrzzdXHxdy+BQFnoGNS6xWMLly OK9lBlRB9QK9xIOTr+4vjNetkMav5CduPenkulIxsEUfKyjcj/CJZ4GWOyGb78PhcD4a c0NUtTxTC8h1gQpbL0AjUtavC4+hoRtYOhztE0ZlxTpnAF38jzqIkfDQ7J6gy5ZIoWEa X4Ac72agUaQ+gW5iP9PyGpalEP+OxrBhlt7LbhZm1L3x4+yZsJrNcUVPRv/tt8kVgBSZ d49XA7rl/32sdMb+md4oZkeWCig/3v9AGw8+4pUQs+nqFxrfT4G9pSvU/FHzJpK12Kli izWA== X-Gm-Message-State: AODbwcAj3JZUz7Z07pNqM2PBqPGktiPKEs9SoWl6UsbQskxCwqSlaSSg +RViTNMjB1u4Gg== X-Received: by 10.99.103.70 with SMTP id b67mr10885746pgc.96.1494923524254; Tue, 16 May 2017 01:32:04 -0700 (PDT) Received: from E107787-LIN (gcc114.osuosl.org. [140.211.9.72]) by smtp.gmail.com with ESMTPSA id y2sm23820994pfk.1.2017.05.16.01.32.02 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Tue, 16 May 2017 01:32:03 -0700 (PDT) From: Yao Qi To: Andreas Arnez Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2 08/19] write_pieced_value: Include transfer size in byte-wise check References: <1494352015-10465-1-git-send-email-arnez@linux.vnet.ibm.com> <1494352015-10465-9-git-send-email-arnez@linux.vnet.ibm.com> Date: Tue, 16 May 2017 08:32:00 -0000 In-Reply-To: <1494352015-10465-9-git-send-email-arnez@linux.vnet.ibm.com> (Andreas Arnez's message of "Tue, 9 May 2017 19:46:04 +0200") Message-ID: <86zied9p8f.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00327.txt.bz2 Andreas Arnez writes: > In write_pieced_value, when checking whether the data can be transferred > byte-wise, the current logic verifies the source- and destination offsets > to be byte-aligned, but not the transfer size. This is fixed. > > --- > gdb/dwarf2loc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c > index 1122c8a..8b5cbc5 100644 > --- a/gdb/dwarf2loc.c > +++ b/gdb/dwarf2loc.c > @@ -1986,7 +1986,8 @@ write_pieced_value (struct value *to, struct value = *from) > this_size =3D (this_size_bits + dest_offset_bits % 8 + 7) / 8; > source_offset =3D source_offset_bits / 8; > dest_offset =3D dest_offset_bits / 8; > - if (dest_offset_bits % 8 =3D=3D 0 && source_offset_bits % 8 =3D=3D= 0) > + if (dest_offset_bits % 8 =3D=3D 0 && source_offset_bits % 8 =3D=3D= 0 > + && this_size_bits % 8 =3D=3D 0) Can you add a comment here saying that "Check whether the data can be transferred byte-wise."? Otherwise, patch is good tome. --=20 Yao (=E9=BD=90=E5=B0=A7)