From: Yao Qi <qiyaoltc@gmail.com>
To: Pedro Alves <palves@redhat.com>
Cc: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 7/7] New test case gdb.base/branch-to-self.exp
Date: Mon, 25 Apr 2016 08:58:00 -0000 [thread overview]
Message-ID: <86zisif4l6.fsf@gmail.com> (raw)
In-Reply-To: <570BC40B.1000908@redhat.com> (Pedro Alves's message of "Mon, 11 Apr 2016 16:34:35 +0100")
Pedro Alves <palves@redhat.com> writes:
> Did you mean to put something here? #error perhaps?
>
> I wonder whether we should just use
>
> while (1);
>
The source C code leading me looking at this issue is "for (;;);", we
can use it too.
>> +with_test_prefix "single-step" {
>> + global testfile
>> +
>> + clean_restart ${testfile}
>> + if ![runto_main] {
>> + return -1
>> + }
>> + set line_num [gdb_get_line_number "loop-line" ${testfile}.c]
>> +
>> + gdb_test "break ${testfile}.c:${line_num}"
>
> Please avoid line numbers in test messages, as they'll change
> as the test evolves in future.
Fixed. Patch below is pushed in.
--
Yao (齐尧)
From f3abeff575541dd80e1facd6d0f920e10f77fede Mon Sep 17 00:00:00 2001
From: Yao Qi <yao.qi@linaro.org>
Date: Mon, 25 Apr 2016 09:53:51 +0100
Subject: [PATCH] New test case gdb.base/branch-to-self.exp
gdb/testsuite:
2016-04-25 Yao Qi <yao.qi@linaro.org>
* gdb.base/branch-to-self.c: New file.
* gdb.base/branch-to-self.exp: New file.
diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index c7c9d58..c919c47 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,8 @@
+2016-04-25 Yao Qi <yao.qi@linaro.org>
+
+ * gdb.base/branch-to-self.c: New file.
+ * gdb.base/branch-to-self.exp: New file.
+
2016-04-22 Yao Qi <yao.qi@linaro.org>
* gdb.trace/unavailable.exp (gdb_collect_globals_test_1): Match
diff --git a/gdb/testsuite/gdb.base/branch-to-self.c b/gdb/testsuite/gdb.base/branch-to-self.c
new file mode 100644
index 0000000..594214b
--- /dev/null
+++ b/gdb/testsuite/gdb.base/branch-to-self.c
@@ -0,0 +1,40 @@
+/* This testcase is part of GDB, the GNU debugger.
+
+ Copyright 2016 Free Software Foundation, Inc.
+
+ This program is free software; you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation; either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU General Public License for more details.
+
+ You should have received a copy of the GNU General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>. */
+
+#include <unistd.h>
+#include <stdlib.h>
+#include <signal.h>
+
+volatile int counter = 0;
+
+static void
+handler (int sig)
+{
+ counter = 5;
+}
+
+int
+main (void)
+{
+ signal (SIGALRM, handler);
+ alarm (5);
+
+ /* Compiler may generate a single instruction which branches to
+ itself. */
+ for (;;); /* loop-line */
+ return 0;
+}
diff --git a/gdb/testsuite/gdb.base/branch-to-self.exp b/gdb/testsuite/gdb.base/branch-to-self.exp
new file mode 100644
index 0000000..2fd3b38
--- /dev/null
+++ b/gdb/testsuite/gdb.base/branch-to-self.exp
@@ -0,0 +1,69 @@
+# This testcase is part of GDB, the GNU debugger.
+#
+# Copyright 2016 Free Software Foundation, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+standard_testfile
+
+if { [build_executable ${testfile}.exp ${testfile} $srcfile {debug}] == -1 } {
+ return -1
+}
+
+with_test_prefix "single-step" {
+ global testfile
+
+ clean_restart ${testfile}
+ if ![runto_main] {
+ return -1
+ }
+ set line_num [gdb_get_line_number "loop-line" ${testfile}.c]
+
+ gdb_test "break ${testfile}.c:${line_num}" "Breakpoint .*" \
+ "set breakpoint"
+ gdb_continue_to_breakpoint "hit breakpoint"
+ gdb_test "si" ".*${testfile}.c:${line_num}.*"
+}
+
+with_test_prefix "break-cond" {
+ global testfile
+
+ foreach_with_prefix side {"host" "target"} {
+
+ clean_restart ${testfile}
+
+ if ![runto_main] {
+ return -1
+ }
+
+ set test "set breakpoint condition-evaluation $side"
+ gdb_test_multiple $test $test {
+ -re "warning: Target does not support breakpoint condition evaluation.\r\nUsing host evaluation mode instead.\r\n$gdb_prompt $" {
+ # Target doesn't support breakpoint condition
+ # evaluation on its side. Skip the test.
+ continue
+ }
+ -re "^$test\r\n$gdb_prompt $" {
+ }
+ }
+
+ set line_num [gdb_get_line_number "loop-line" ${testfile}.c]
+ gdb_test "break ${testfile}.c:${line_num} if counter > 3" \
+ "Breakpoint .*" "set breakpoint with condition"
+
+ gdb_continue_to_breakpoint "continue to break"
+
+ gdb_test "p counter" ".* = 5"
+ }
+}
prev parent reply other threads:[~2016-04-25 8:58 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 16:10 [PATCH 0/7 V2] Step over instruction branches to itself Yao Qi
2016-03-23 16:10 ` [PATCH 3/7] Force to insert software single step breakpoint Yao Qi
2016-04-11 14:31 ` Pedro Alves
2016-04-13 16:21 ` Yao Qi
2016-04-19 14:54 ` Yao Qi
2016-04-19 15:17 ` Pedro Alves
2016-04-20 7:50 ` Yao Qi
2016-04-22 16:36 ` Pedro Alves
2016-04-25 8:40 ` Yao Qi
2016-03-23 16:10 ` [PATCH 1/7] New test case gdb.trace/signal.exp Yao Qi
2016-04-08 16:52 ` Pedro Alves
2016-04-11 8:41 ` Yao Qi
2016-04-11 14:04 ` Pedro Alves
2016-04-22 10:53 ` Yao Qi
2016-04-26 12:57 ` Pedro Alves
2016-04-11 14:08 ` Pedro Alves
2016-03-23 16:10 ` [PATCH 5/7] [GDBserver] Don't error in reinsert_raw_breakpoint if bp->inserted Yao Qi
2016-04-11 14:54 ` Pedro Alves
2016-03-23 16:10 ` [PATCH 2/7] Deliver signal in hardware single step Yao Qi
2016-04-11 14:10 ` Pedro Alves
2016-04-22 10:54 ` Yao Qi
2016-03-23 16:10 ` [PATCH 6/7] Resume the inferior with signal rather than stepping over Yao Qi
2016-04-11 15:29 ` Pedro Alves
2016-03-23 16:10 ` [PATCH 4/7] Insert breakpoint even when the raw breakpoint is found Yao Qi
2016-04-11 14:41 ` Pedro Alves
2016-04-12 9:04 ` Yao Qi
2016-04-12 9:41 ` Pedro Alves
2016-04-25 8:45 ` Yao Qi
2016-03-23 16:26 ` [PATCH 7/7] New test case gdb.base/branch-to-self.exp Yao Qi
2016-04-11 15:34 ` Pedro Alves
2016-04-25 8:58 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86zisif4l6.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).