From: Yao Qi <qiyaoltc@gmail.com>
To: Andreas Arnez <arnez@linux.vnet.ibm.com>
Cc: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gnu_vector.exp: Respect `should_kfail' for PR8549
Date: Wed, 20 Jan 2016 09:32:00 -0000 [thread overview]
Message-ID: <86ziw0sik1.fsf@gmail.com> (raw)
In-Reply-To: <m3d1sxs8zo.fsf@oc1027705133.ibm.com> (Andreas Arnez's message of "Tue, 19 Jan 2016 19:46:19 +0100")
Andreas Arnez <arnez@linux.vnet.ibm.com> writes:
> Doing the KFAIL based on the target triplet would miss the point of this
> test on s390x, because on the same target "s390x-ibm-linux-gnu" the test
> shall succeed if the CPU has vector registers and the vector ABI is
> used, but is known to fail if a non-vector ABI is used. (Note that the
> main reason for enhancing the gnu_vector test case was to verify GDB's
> correct treatment of the s390x vector ABI.)
Could you add some comments in the test case about what you said above?
>
> But testing against some expected return value in this case is certainly
> wrong. I suggest to change my patch like follows. WDYT?
That is fine with me.
--
Yao (齐尧)
prev parent reply other threads:[~2016-01-20 9:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 16:33 Andreas Arnez
2016-01-19 17:33 ` Yao Qi
2016-01-19 18:46 ` Andreas Arnez
2016-01-20 9:32 ` Yao Qi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86ziw0sik1.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).