From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76208 invoked by alias); 20 Jan 2016 09:32:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76193 invoked by uid 89); 20 Jan 2016 09:32:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:774, HX-Received:Wed, gnu_vector.exp, gnu_vectorexp X-HELO: mail-pa0-f52.google.com Received: from mail-pa0-f52.google.com (HELO mail-pa0-f52.google.com) (209.85.220.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Wed, 20 Jan 2016 09:32:07 +0000 Received: by mail-pa0-f52.google.com with SMTP id yy13so1914504pab.3 for ; Wed, 20 Jan 2016 01:32:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type :content-transfer-encoding; bh=Z99GHfK+PbrDK+JBxkUx23aCyQMdGjzHmS5R+6rnRf0=; b=BZceU89TfADg8uhhbcdDPWj+G9V2d+thxfAITog6CdSeYEkGfwQPaMji8ehpnuuR8D niwmB6ZE9LRLTfYBKNcSZtDjP6iEduFrxQ6wKnZcAnOfTs5OOr6t0LA/roednIXZntcb HWukgy19HPAqRnHUZ/MqcdM+MWxhS1fj1jCwhzLl/6RKiHUiq0bfJqhCvkD1r4g0QjCO HlCKFBuZQC6Ag7g+yZuDQ7qLWbdIbmq4FC9xYssTvT2y6nlQGgKySybHPmeTPvhqy+YE 5ONIDrVTlpBOXQ+FDYexUUbB5npxfhXtaqDEQD2aVmoi94IOhPCzzI7zKamzj9JD6H4O XnFQ== X-Gm-Message-State: ALoCoQlZYvjjXNDG1WZ4KTMhmJBT33m7sMgpJO67hbCtBAI2FwVREy2vesG9xk612nk8XlRZBAruIa/9RIv9GT3aGeYvvLoJfg== X-Received: by 10.67.24.33 with SMTP id if1mr51189960pad.137.1453282326158; Wed, 20 Jan 2016 01:32:06 -0800 (PST) Received: from E107787-LIN (gcc1-power7.osuosl.org. [140.211.15.137]) by smtp.gmail.com with ESMTPSA id 2sm47299212pfr.22.2016.01.20.01.32.03 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Wed, 20 Jan 2016 01:32:05 -0800 (PST) From: Yao Qi To: Andreas Arnez Cc: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH] gnu_vector.exp: Respect `should_kfail' for PR8549 References: <864me9tqxc.fsf@gmail.com> Date: Wed, 20 Jan 2016 09:32:00 -0000 In-Reply-To: (Andreas Arnez's message of "Tue, 19 Jan 2016 19:46:19 +0100") Message-ID: <86ziw0sik1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2016-01/txt/msg00465.txt.bz2 Andreas Arnez writes: > Doing the KFAIL based on the target triplet would miss the point of this > test on s390x, because on the same target "s390x-ibm-linux-gnu" the test > shall succeed if the CPU has vector registers and the vector ABI is > used, but is known to fail if a non-vector ABI is used. (Note that the > main reason for enhancing the gnu_vector test case was to verify GDB's > correct treatment of the s390x vector ABI.) Could you add some comments in the test case about what you said above? > > But testing against some expected return value in this case is certainly > wrong. I suggest to change my patch like follows. WDYT? That is fine with me. --=20 Yao (=E9=BD=90=E5=B0=A7)