* [PATCH] gdb: Add missing single quotation mark in README
@ 2024-05-09 8:35 Tiezhu Yang
2024-05-09 9:48 ` Eli Zaretskii
2024-05-09 14:01 ` Tom Tromey
0 siblings, 2 replies; 4+ messages in thread
From: Tiezhu Yang @ 2024-05-09 8:35 UTC (permalink / raw)
To: gdb-patches
Maybe forgot to add a single quotation mark for --with-system-zlib
in commit 7f0bd4202c23 ("Update gdb's configure instructions"), just
add it.
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---
gdb/README | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/README b/gdb/README
index 763089bb02d..d85c37d5d17 100644
--- a/gdb/README
+++ b/gdb/README
@@ -451,7 +451,7 @@ more obscure GDB `configure' options are not listed here.
library supplied as part of GDB. Readline 7 or newer is required;
this is enforced by the build system.
-`--with-system-zlib
+`--with-system-zlib'
Use the zlib library installed on the host, rather than the
library supplied as part of GDB.
--
2.42.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gdb: Add missing single quotation mark in README
2024-05-09 8:35 [PATCH] gdb: Add missing single quotation mark in README Tiezhu Yang
@ 2024-05-09 9:48 ` Eli Zaretskii
2024-05-09 14:01 ` Tom Tromey
1 sibling, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2024-05-09 9:48 UTC (permalink / raw)
To: Tiezhu Yang; +Cc: gdb-patches
> From: Tiezhu Yang <yangtiezhu@loongson.cn>
> Date: Thu, 9 May 2024 16:35:10 +0800
>
> Maybe forgot to add a single quotation mark for --with-system-zlib
> in commit 7f0bd4202c23 ("Update gdb's configure instructions"), just
> add it.
Thanks, fixed.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gdb: Add missing single quotation mark in README
2024-05-09 8:35 [PATCH] gdb: Add missing single quotation mark in README Tiezhu Yang
2024-05-09 9:48 ` Eli Zaretskii
@ 2024-05-09 14:01 ` Tom Tromey
2024-05-10 2:03 ` Tiezhu Yang
1 sibling, 1 reply; 4+ messages in thread
From: Tom Tromey @ 2024-05-09 14:01 UTC (permalink / raw)
To: Tiezhu Yang; +Cc: gdb-patches
>>>>> Tiezhu Yang <yangtiezhu@loongson.cn> writes:
> Maybe forgot to add a single quotation mark for --with-system-zlib
> in commit 7f0bd4202c23 ("Update gdb's configure instructions"), just
> add it.
Thanks. I think this would qualify as an obvious fix.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] gdb: Add missing single quotation mark in README
2024-05-09 14:01 ` Tom Tromey
@ 2024-05-10 2:03 ` Tiezhu Yang
0 siblings, 0 replies; 4+ messages in thread
From: Tiezhu Yang @ 2024-05-10 2:03 UTC (permalink / raw)
To: Tom Tromey; +Cc: gdb-patches
On 05/09/2024 10:01 PM, Tom Tromey wrote:
>>>>>> Tiezhu Yang <yangtiezhu@loongson.cn> writes:
>
>> Maybe forgot to add a single quotation mark for --with-system-zlib
>> in commit 7f0bd4202c23 ("Update gdb's configure instructions"), just
>> add it.
>
> Thanks. I think this would qualify as an obvious fix.
> Approved-By: Tom Tromey <tom@tromey.com>
Thanks for your reply and Approved-By, I noticed that this change has
been merged as commit 5021daf30339 ("Fix typo in gdb/README.") by Eli.
---
Fix typo in gdb/README.
Patch from Tiezhu Yang <yangtiezhu@loongson.cn>.
---
So it seems that there is no chance to add your tag and then push it
again.
Thanks,
Tiezhu
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-05-13 9:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-09 8:35 [PATCH] gdb: Add missing single quotation mark in README Tiezhu Yang
2024-05-09 9:48 ` Eli Zaretskii
2024-05-09 14:01 ` Tom Tromey
2024-05-10 2:03 ` Tiezhu Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).