From: Tom Tromey <tom@tromey.com>
To: Dmitry Neverov <dmitry.neverov@jetbrains.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v3][PR symtab/30520 4/4] gdb/symtab: use symbol name matcher for all segments in a qualified name
Date: Tue, 07 May 2024 11:26:27 -0600 [thread overview]
Message-ID: <871q6da5z0.fsf@tromey.com> (raw)
In-Reply-To: <20240506150920.1220092-4-dmitry.neverov@jetbrains.com> (Dmitry Neverov's message of "Mon, 6 May 2024 17:09:20 +0200")
>>>>> "Dmitry" == Dmitry Neverov <dmitry.neverov@jetbrains.com> writes:
Thanks for the patch.
Dmitry> std::vector<std::string_view> name_vec
Dmitry> = lookup_name_without_params.split_name (lang);
Dmitry> - std::string last_name (name_vec.back ());
Dmitry> -
Dmitry> - lookup_name_info last_segment_lookup_name (
Dmitry> - last_name, symbol_name_match_type::FULL, completing, true);
Dmitry> + std::vector<std::string> name_str_vec (name_vec.begin (), name_vec.end ());
I was going to suggest changing split_name to simply return this vector,
but I'd forgotten that cooked-index.c also uses it.
Dmitry> + std::vector<lookup_name_info> segment_lookup_names;
Dmitry> + segment_lookup_names.reserve (name_vec.size ());
Dmitry> + for (auto &segment_name : name_str_vec)
Dmitry> + {
Dmitry> + segment_lookup_names.emplace_back (segment_name,
Dmitry> + symbol_name_match_type::FULL, completing, true);
This should be indented more to line up with "segment_name" from the
previous line.
Otherwise this looks good to me.
Tom
next prev parent reply other threads:[~2024-05-07 17:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-06 15:09 [PATCH v3][PR symtab/30520 1/4] gdb/symtab: check name matches before expanding a CU Dmitry Neverov
2024-05-06 15:09 ` [PATCH v3][PR symtab/30520 2/4] gdb/symtab: reuse last segment lookup name info by creating it outside the loop Dmitry Neverov
2024-05-07 17:09 ` Tom Tromey
2024-05-06 15:09 ` [PATCH v3][PR symtab/30520 3/4] gdb/symtab: compute match_type " Dmitry Neverov
2024-05-07 17:10 ` Tom Tromey
2024-05-06 15:09 ` [PATCH v3][PR symtab/30520 4/4] gdb/symtab: use symbol name matcher for all segments in a qualified name Dmitry Neverov
2024-05-06 15:23 ` Dmitry Neverov
2024-05-07 17:26 ` Tom Tromey [this message]
2024-05-07 17:03 ` [PATCH v3][PR symtab/30520 1/4] gdb/symtab: check name matches before expanding a CU Tom Tromey
2024-05-08 11:32 ` Dmitry.Neverov
2024-05-08 15:48 ` Tom Tromey
2024-05-09 5:55 ` Dmitry.Neverov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q6da5z0.fsf@tromey.com \
--to=tom@tromey.com \
--cc=dmitry.neverov@jetbrains.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).