From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by sourceware.org (Postfix) with ESMTPS id 90CCB385E83A for ; Tue, 7 May 2024 17:26:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 90CCB385E83A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 90CCB385E83A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715102791; cv=none; b=l6Zf6J30bPlg046mnud6Rtw3vfryR6eY/AvAkkMLz9KGpUcegqJXTMEhB9V0xkwraRduBnIj+5wBjpJfBMrCyPFt+p/hOOMmh8nl/SX5Zcu+nCU5+u7WtBFwTKHf41WCPQRyuyomEdteervMa0mafDnb0On7BHli4WX5ZjnLIV8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715102791; c=relaxed/simple; bh=t+5NyxviGSmrL2cSG/me2D1k+qnhuJtdn4EQhHWNe+c=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=iWH9S+p7AHHS+Ot9S6bUtWVy5RKzD6QMlmP2noITpqsjpdMSn4hvVfujLGbTLP+npOyNkrhkSAdqS+gIT0uKul/OXQQF8jAQIagled4RcHz3ZO4ZJ/yvgsQkanIse7aU/OSJFWvK4HUYbGsONkv8mraw27nLRt1+BTEY29LhgQQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6004a.ext.cloudfilter.net ([10.0.30.197]) by cmsmtp with ESMTPS id 4OCKsZWiOSqsh4OaDs87PM; Tue, 07 May 2024 17:26:29 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 4OaCsVWXquv6X4OaCsHLhW; Tue, 07 May 2024 17:26:28 +0000 X-Authority-Analysis: v=2.4 cv=YbZ25BRf c=1 sm=1 tr=0 ts=663a6444 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=TpHVaj0NuXgA:10 a=Qbun_eYptAEA:10 a=RtkggBvCAAAA:8 a=OlCQpBykCh21EHreueAA:9 a=UdJnLIV5m_Qj24SUPjus:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=c9ioVk1Wc+2dPPZ686TQIl/reE5HKGYheR8xiE0Qje8=; b=xg54vWhwMsIvE0FZEZ2twvzQhV fVboUBXgjFivn6ShplUIIpq1smevNy8Ea+ZrFNZQ799Lt1AbKOvo1K3kghuvnu+XHFnLgWNVKz3+t 7urdFFeQptuaiTjp63cKFysN1; Received: from 97-122-86-252.hlrn.qwest.net ([97.122.86.252]:34104 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1s4OaC-0034cg-0L; Tue, 07 May 2024 11:26:28 -0600 From: Tom Tromey To: Dmitry Neverov Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v3][PR symtab/30520 4/4] gdb/symtab: use symbol name matcher for all segments in a qualified name In-Reply-To: <20240506150920.1220092-4-dmitry.neverov@jetbrains.com> (Dmitry Neverov's message of "Mon, 6 May 2024 17:09:20 +0200") References: <20240506150920.1220092-1-dmitry.neverov@jetbrains.com> <20240506150920.1220092-4-dmitry.neverov@jetbrains.com> X-Attribution: Tom Date: Tue, 07 May 2024 11:26:27 -0600 Message-ID: <871q6da5z0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.86.252 X-Source-L: No X-Exim-ID: 1s4OaC-0034cg-0L X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-86-252.hlrn.qwest.net (murgatroyd) [97.122.86.252]:34104 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJRvoUe5ksjOlrSZzuSmgytrpLJAjE3beAgA+1oE2tn9vMJclRtJGzfEjLs7ly7nZb8GuDPfGuOA5BnoB9/dFy36Qk/5H+nDO/lXcuHetXUVm7JnMfXm nwpsEzldZvVvJ0/549eQCCHuLP77AYOpxt4DcMMZymAiP+ts724J9YWmebOO2S2iWjaOhcAaitbTEC/09Xurs1LqX3fI9rin9K0= X-Spam-Status: No, score=-3014.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Dmitry" == Dmitry Neverov writes: Thanks for the patch. Dmitry> std::vector name_vec Dmitry> = lookup_name_without_params.split_name (lang); Dmitry> - std::string last_name (name_vec.back ()); Dmitry> - Dmitry> - lookup_name_info last_segment_lookup_name ( Dmitry> - last_name, symbol_name_match_type::FULL, completing, true); Dmitry> + std::vector name_str_vec (name_vec.begin (), name_vec.end ()); I was going to suggest changing split_name to simply return this vector, but I'd forgotten that cooked-index.c also uses it. Dmitry> + std::vector segment_lookup_names; Dmitry> + segment_lookup_names.reserve (name_vec.size ()); Dmitry> + for (auto &segment_name : name_str_vec) Dmitry> + { Dmitry> + segment_lookup_names.emplace_back (segment_name, Dmitry> + symbol_name_match_type::FULL, completing, true); This should be indented more to line up with "segment_name" from the previous line. Otherwise this looks good to me. Tom