From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x32a.google.com (mail-ot1-x32a.google.com [IPv6:2607:f8b0:4864:20::32a]) by sourceware.org (Postfix) with ESMTPS id E39643858433 for ; Thu, 18 Apr 2024 15:45:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E39643858433 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E39643858433 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::32a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713455113; cv=none; b=WAeHKXW/54KpqT5b9CuaY6BEy8ONEij3xq0N76l1WdKfq8yQ8iEBuQbx/Tbd5X7jX8HQTg9hr5Z8Y0bgyRb0G8ZJhqp84cvl5lwM8k1dqDbW6FFwkEIXyDJiB6JW3/GCZzxaha/84heDsuKG2yg38M5/ypcnlymBpV/6RWcMNXU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713455113; c=relaxed/simple; bh=9d+mBpexEyuCkvkFXVOp/xbTcPaUF3Ey0DFCpoJxGnc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=X0MtYxwTMLWRabzTFGGFGC0AYingC3y7ssYAszZajZPJfDUuTMarLaI8vneCfjBa9qeDoT0chFXE1EAwUmxhUXLtNMFvoi1A1r48Cd/HWzX5GeyKCVhlc+uBntwTb7IkvWZM4QZpVpoQg7nZvRBv3RD2+gj+JtQqA1fLCvtQwyo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ot1-x32a.google.com with SMTP id 46e09a7af769-6eb6b9e1808so704876a34.3 for ; Thu, 18 Apr 2024 08:45:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1713455111; x=1714059911; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=501zg+GnM6adbSFrmPHo52QF3avfK5JA+tOoXUop0AI=; b=cSED8Itb49fxk35f45KmMAMgpY6NU9Aq1V/1/KmiRe1VlIslJxEezLGOPpyOz9Bjf2 FsUUaknZXXE8qQ7jew79WQF1VYhS87umZwFbN8xSHZ0QAvvsNtsmvyUncH3nAgh6Ezvi ARxtkWu9JODJKqvDyolwsUvlQs4nC3h349if9xNaSq0uBoPnS72INUQsfaTQcWlmQ+rS sl4qiiJ5hInqQnAM/S6dKZsGN0Yj/6VKj2eSymif1fxIhnjJ0GkoUSQDAWpmtP5dmyvK /2nYr/GY1Z1wXVRpw3p2z7MSIvAceI4GEnanwzJKJtRY339wGJnGM1fNZaOAI3yJ4oIh GcTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713455111; x=1714059911; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=501zg+GnM6adbSFrmPHo52QF3avfK5JA+tOoXUop0AI=; b=cwcw7ca0YxSNkM0jweEeh1NshqkLGSUUBMdmn1MUreNINrkQoGylkLYGrKUwIVLAYw wrQDaOY/d9XKG3gXrGcnIxjSKikhmtIva92EdzlNNy58Sy+qbGgLsPXfkEcrHol7mB3m uzAAU0z5zCqw9L24yx5LOyskf6F5wFzmF2vtR0Sm020ieTAXSm59610XA55I+dnrwCbJ yT91WRRJlFQwgKYvVvjbuRz/nM2tOxwDJ521c0CVVwBwws3eIef8BXYGc5ghMk4j3D48 6+baGNMUuFlzpmKpae9Y27DLa6rm4N58Eorvpuxj375bnHw68qsBeUzGA2/sH5B7vs60 Po2w== X-Forwarded-Encrypted: i=1; AJvYcCWz265xNBB26/0SXFrEP/DfX6c+myBXOyA5Q7kgkMBSj4X+TDFm003WwSHEpzsn+iSKEAgDGlpF8tNJnLZ4m26NDQPhhGBlTevmLg== X-Gm-Message-State: AOJu0Yzj1D3j7vNlax/L1GUsaKpsiAz7+6UuqNkv4HTQVtIO03VaXKl3 VMGXha4YvRyj3hEq2DVAcgpaiguyiMQnmN9lnkqffCuieQflWuv/8vik6IZxVlHGluTOeHxErzU = X-Google-Smtp-Source: AGHT+IGjBX6qVb6GD1XFPc3w6hJfJxWmxjAXtKRCg12opu7KoAFlrcSdQvF5HQHdpqLHvU9qCmQsRg== X-Received: by 2002:a05:6870:b609:b0:22f:bdb:54d0 with SMTP id cm9-20020a056870b60900b0022f0bdb54d0mr3664681oab.11.1713455109732; Thu, 18 Apr 2024 08:45:09 -0700 (PDT) Received: from murgatroyd (97-122-82-115.hlrn.qwest.net. [97.122.82.115]) by smtp.gmail.com with ESMTPSA id z11-20020a029f0b000000b0047ec1007689sm469834jal.71.2024.04.18.08.45.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Apr 2024 08:45:09 -0700 (PDT) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 3/4] Add check-include-guards.py to pre-commit References: <20240417-header-check-v1-0-a60f610f5bcc@adacore.com> <20240417-header-check-v1-3-a60f610f5bcc@adacore.com> <7c984d39-27a2-4d6e-aea7-08ffc2417cdb@simark.ca> X-Attribution: Tom Date: Thu, 18 Apr 2024 09:45:08 -0600 In-Reply-To: <7c984d39-27a2-4d6e-aea7-08ffc2417cdb@simark.ca> (Simon Marchi's message of "Thu, 18 Apr 2024 11:33:01 -0400") Message-ID: <871q72zncr.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon> The regex is a bit hard to read... can you add a comment to indicate Simon> what this indends to match? I think this does not match header files Simon> under gdb/testsuite (because they are deeper than what the regex would Simon> match)? I added this: # This matches headers in gdbsupport, gdbserver, gdb, and the # immediate subdirectories of gdb (e.g., gdb/nat) -- but, # importantly, not gdb/testsuite/*/*.h. I went a little too fast sending v2, should have waited a bit. Anyway I don't think this addition warrants a v3. Tom