From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 151123858401 for ; Wed, 3 Apr 2024 15:17:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 151123858401 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 151123858401 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712157424; cv=none; b=jUSJF1+yqhqRpKjUj2L5/fpN0R1aw8xYGPYMvXK5TQi4Zs0c1h0Ds0YP2ABstZVCB1heoIKTB/pNsMq2tVU6i73WCNitCLLb6UOC9QtsaLEJQJXleWgsqNkh/jKRyvAWSeJdO/nxTGDUBcW8Qw4urYtc7pA3cNAU3CrZhUp0CkI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712157424; c=relaxed/simple; bh=X4py+Tzpmo8NSOVq/P6jdVi8P7T4VdGjiits1yvChdc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=x8F9nqubLAt/xnGXgUFoE/iVhaGxxZzaM4ofDf2gBSl906cCtpDE1rWNpTcweW9Y1Il1BThFoNMO5l16kzc7mZCPUQC20CmkNrNpUUyU192jB0GvvKqiVUmtFKNOtjjP+dSFzhwHFj4rWbt6b76EJtJlrHCXCJjrlxj8R/P5nAQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5009a.ext.cloudfilter.net ([10.0.29.176]) by cmsmtp with ESMTPS id rsjfr0lNWtf2Qs2MGrA02h; Wed, 03 Apr 2024 15:17:01 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id s2MFrwMONELAWs2MGrpgZ9; Wed, 03 Apr 2024 15:17:00 +0000 X-Authority-Analysis: v=2.4 cv=EfzOQumC c=1 sm=1 tr=0 ts=660d72ec a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=raytVjVEu-sA:10 a=Qbun_eYptAEA:10 a=zstS-IiYAAAA:8 a=FXvbO_WeNPzRgb1lClgA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=AlZd6rldE+EXGGUOMugZVEjzI6N/dgVHMpRQw+g6jzI=; b=l3Lmf5+C6zRLD6kI6J9qjhTlpJ ZB1s4D7OYL1tGZ/DeXZQCeR8RhJwOnAskGRwsQVwVaR0qo+4zQB/7nwSu4v44b4nDLkCQtSEaahfv jZizrubBpYCOUsf192z86WFNB; Received: from 97-122-82-115.hlrn.qwest.net ([97.122.82.115]:58796 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rs2MF-003mjx-1z; Wed, 03 Apr 2024 09:16:59 -0600 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/7] Fix race in DWARF reader References: <20240217-dwarf-race-relocate-v1-0-d3d2d908c1e8@tromey.com> X-Attribution: Tom Date: Wed, 03 Apr 2024 09:16:58 -0600 In-Reply-To: <20240217-dwarf-race-relocate-v1-0-d3d2d908c1e8@tromey.com> (Tom Tromey's message of "Sat, 17 Feb 2024 18:10:01 -0700") Message-ID: <871q7m8oid.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.82.115 X-Source-L: No X-Exim-ID: 1rs2MF-003mjx-1z X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-82-115.hlrn.qwest.net (murgatroyd) [97.122.82.115]:58796 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfJecnEIp6Byv3rQYNqTUSIZcVowL9Jty8Z1KkO25+9OUzRM715PgPyoB3GJ4hviFWjw6QMUVhUidunOW4TdZFCpbDEPj+aVlKpdBbNYckt/mY1RewF7R yD3r2eJsROs9IUI797BGwWjpB8nzmc6Pqokkym1S4JnLmsWmpi3+K35c7MsfY2L6uR1qzwpU53ZgknKzfzypd27kCBvc9dmod5Q= X-Spam-Status: No, score=-3015.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey writes: Tom> The background DWARF reader turns out to have a few races. This Tom> series fixes one that occurs when the indexer runs at the same time as Tom> DWARF relocation. Tom> Most of the series is just cleanup / preparation. Tom> The main patch affects MIPS16. I can't test this -- I tried on a MIPS Tom> machine in the GCC compile farm, but unfortunately the relevant Tom> gdb.arch test says that the processor doesn't support MIPS16. It's Tom> possible this code is simply dead; I do not know. Elsewhere I mentioned that I had a different idea for this series. It seems to me that most (or maybe even all) the calls to dwarf2_per_objfile::adjust aren't really needed. Many of them only affect lookup tables, where the adjustment isn't needed. This includes all calls made by the indexer. Some of the calls (like the one in read_attribute_value) even seem to be wrong. So, I wrote a short series to remove these. Unfortunately, though, it's hard to know for sure if the result is correct, given that I don't know how to test MIPS16. I could probably test some simple things ("break") by debugging gdb while examining (but not running) a MIPS16 program. I'm not sure if that's really sufficient though. I'd appreciate some insight if you have any. thanks, Tom