public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@adacore.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Run isort
Date: Tue, 02 Apr 2024 11:20:22 -0600	[thread overview]
Message-ID: <871q7nadgp.fsf@tromey.com> (raw)
In-Reply-To: <20240320163957.3349962-3-tromey@adacore.com> (Tom Tromey's message of "Wed, 20 Mar 2024 10:38:43 -0600")

>>>>> "Tom" == Tom Tromey <tromey@adacore.com> writes:

Tom> This patch is the result of running 'isort .' in the gdb directory.

Tom> diff --git a/gdb/python/lib/gdb/__init__.py b/gdb/python/lib/gdb/__init__.py
Tom> index 5b96605240e..3589117d411 100644
Tom> --- a/gdb/python/lib/gdb/__init__.py
Tom> +++ b/gdb/python/lib/gdb/__init__.py
 
Tom>  # Note that two indicators are needed here to silence flake8.
Tom> -# isort: split
Tom>  from _gdb import *  # noqa: F401,F403
 
Tom> +# isort: split
Tom> +
Tom>  # Historically, gdb.events was always available, so ensure it's
Tom>  # still available without an explicit import.
Tom> +# isort: split
Tom>  import _gdbevents as events
 
I forgot I had tried changing how the splits were done.  I moved this
bit into the first patch (and also removed the second split, as it isn't
needed).  There was also a similar change in dap/__init__.py.

I verified that this doesn't impact anything -- isort still generates
the same output.

I'm checking these in.

Tom

  reply	other threads:[~2024-04-02 17:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-20 16:38 [PATCH 0/2] Use isort in gdb Tom Tromey
2024-03-20 16:38 ` [PATCH 1/2] Prepare gdb for isort Tom Tromey
2024-03-20 16:38 ` [PATCH 2/2] Run isort Tom Tromey
2024-04-02 17:20   ` Tom Tromey [this message]
2024-03-20 19:03 ` [PATCH 0/2] Use isort in gdb Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871q7nadgp.fsf@tromey.com \
    --to=tromey@adacore.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).