From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id A0CF73858C52 for ; Wed, 17 Jan 2024 15:32:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A0CF73858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A0CF73858C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705505537; cv=none; b=x/z4XwuA6orDobBL2+Lfcep0Y76Gm3TCdK6IOlBTtHc8Dq6rJGbEiLOhtE7Rlpy0AUvd8uPrff8+1xJw3ZBCLBA59HGNVoGmrBH10HPFKnB7vE+MYyv+TLkU5Uj34fX8EaBHeBn6FVXhnN8m5I4dVU97twAcFweO218ADnnXK8E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705505537; c=relaxed/simple; bh=raOHeq/ni4BuIzjH+s3RThj2AdmaN7bm6qKzExJ16SU=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=YclY5OnxXLCakVYBmJwD0V5/Y3UZWKDC2Vd+yZSFNCmfWplWjIz1sYs8JTVlStyqQ147BxaM/MJ9IsEduG8zfIL1QGkjdIC1DiNMQHD5Lq3qYLnM1yT9ZjK7CSVYJHBURP8U2GtibYiZvumsYUByZfRIQvMi6C9RQT1zjYnuqoE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705505535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ykzk7vB/v3jmersOlaPZBBDA5p3ZGpQeT2Upm2n5q/g=; b=VcvrUI3ycbzToaPO/k1HpC5clBSBRMS+V4JthXgs37xuBLH++hzWYYRcHhfXMauVFTwa0A xOWFHxXem/wIaSvQFKZ681yDK+asKBynvgi0v0bKUvjFFkY5Q+dT/N8H86iz5TeaNWCwbE Gq99PUlSvACkxXtFsaHNWwgaLsWvAHg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-625-JGwMCW70PtmivyNfqE4k_w-1; Wed, 17 Jan 2024 10:32:13 -0500 X-MC-Unique: JGwMCW70PtmivyNfqE4k_w-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40e478693bcso46760855e9.1 for ; Wed, 17 Jan 2024 07:32:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705505533; x=1706110333; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ykzk7vB/v3jmersOlaPZBBDA5p3ZGpQeT2Upm2n5q/g=; b=LrMx5KcfvJ0DFi2hFqzkKITCo0Bt8XOrcFnyx+oiTBirJjy3fjVC38wTfgI8zoAu1n SqXVC4mmCxsoCe2VbJ9uXcmzadUO1VBCbhIFLOhZGRLBvFRVi/mzDd4hvN4pTkYZ+Tq8 b/XqUz2XGc5qAdLY836U4PG7ed6p9uEal4f/PMw9Dj0wwtzUs5UwmJZEU81dUxDwNzPJ qSBb3NrIvKEvvLAZ6Go20Ji4hoRP8Yk3YbOAKJkFgF8w4QocZfvn1FfZ0pATPB+5mFh9 QCRECyhzt07IQ2DV5isz18X/ojlhuM0Yt0dBT9+1AZdFUR6WBHve5NylOKkjMRjEWZkE 1bIA== X-Gm-Message-State: AOJu0Yx4xI9Tc4XPkQIzbAiEriF7tlcQrj05lgVX1+rkEq4Sl6oLIU2I cWyBEu3BWsEHiHNTIVjLGDVexWIl452yJ6Y9Po4ohr/0izoAhk+C1S8P5nz0HpwgH/diluSvryO tMSIp+D5UHUY06XjlH6VQcxgdtYIOkw== X-Received: by 2002:a05:600c:2349:b0:40e:557d:a5a7 with SMTP id 9-20020a05600c234900b0040e557da5a7mr668950wmq.160.1705505532778; Wed, 17 Jan 2024 07:32:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IFwBLRcRemYGkyUAUtG2SguUfGxGd/zi5UU99Z7O0BJD1rkgKjVKopvSL/deTzwwiEBUdwsFw== X-Received: by 2002:a05:600c:2349:b0:40e:557d:a5a7 with SMTP id 9-20020a05600c234900b0040e557da5a7mr668943wmq.160.1705505532329; Wed, 17 Jan 2024 07:32:12 -0800 (PST) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id p21-20020a05600c359500b0040e3488f16dsm22646278wmq.12.2024.01.17.07.32.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jan 2024 07:32:12 -0800 (PST) From: Andrew Burgess To: Tom de Vries , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: handle long filenames in gdb.base/startup-with-shell.exp In-Reply-To: <392f3495-5d71-4cba-b456-3484498f906c@suse.de> References: <8be51f9325a83a446404cf595bbe60b330af79e0.1705485491.git.aburgess@redhat.com> <392f3495-5d71-4cba-b456-3484498f906c@suse.de> Date: Wed, 17 Jan 2024 15:32:11 +0000 Message-ID: <871qag6kn8.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom de Vries writes: > On 1/17/24 10:58, Andrew Burgess wrote: >> I got a report of a failure from Linaro's CI testing for the test >> gdb.base/startup-with-shell.exp. >> >> Looking at the log I see this: >> >> (gdb) PASS: gdb.base/startup-with-shell.exp: startup_with_shell = on; run_args = *.unique-extension: inferior started >> print argv[1] >> $1 = 0xfffed978 "/home/tcwg-build/workspace/tcwg_gnu_4/abe/builds/armv8l-unknown-linux-gnueabihf/armv8l-unknown-linux-gnueabihf/gdb-gdb.git~master/gdb/testsuite/outputs/gdb.base/startup-with-shell/unique-file.unique-e"... >> (gdb) FAIL: gdb.base/startup-with-shell.exp: startup_with_shell = on; run_args = *.unique-extension: first argument expanded >> >> Notice that the value of $1 was truncated (indicated by the trailing >> ellipses), and as a result it isn't going to match the expected output >> pattern. >> >> Avoid this by adding a call to 'set print characters unlimited' which >> allows GDB to print strings of any length. > > Hi Andrew, > > LGTM. > > I don't see the FAIL in my usual setup, but I managed to reproduce it by > using "set print characters 20". > > FWIW, I noticed with target native-extended-gdbserver: > ... > FAIL: gdb.base/startup-with-shell.exp: startup_with_shell = on; run_args > = *.unique-extension: first argument expanded > FAIL: gdb.base/startup-with-shell.exp: startup_with_shell = on; run_args > = $TEST: testing first argument > ... > but that's both with and without your patch. PR28392 ( > https://sourceware.org/bugzilla/show_bug.cgi?id=28392 ) looks related. These failures (along with a lot of other problems) are fixed by this series: https://inbox.sourceware.org/gdb-patches/cover.1704809585.git.aburgess@redhat.com Thanks, Andrew > > Approved-By: Tom de Vries > > Thanks, > - Tom > >> --- >> gdb/testsuite/gdb.base/startup-with-shell.exp | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/gdb/testsuite/gdb.base/startup-with-shell.exp b/gdb/testsuite/gdb.base/startup-with-shell.exp >> index b73d5d740f5..d5ec503dceb 100644 >> --- a/gdb/testsuite/gdb.base/startup-with-shell.exp >> +++ b/gdb/testsuite/gdb.base/startup-with-shell.exp >> @@ -59,6 +59,7 @@ proc initial_setup_simple { startup_with_shell run_args } { >> >> with_test_prefix "startup_with_shell = on; run_args = *.unique-extension" { >> initial_setup_simple "on" "$unique_file_dir/*.unique-extension" >> + gdb_test_no_output "set print characters unlimited" >> gdb_test "print argv\[1\]" "\\\$$decimal = $hex \"$unique_file\"" \ >> "first argument expanded" >> } >> >> base-commit: 1b346e50485ee450e8103e4b1704b43f61bc39f7