From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 4E3713858C2C for ; Thu, 4 Jan 2024 09:43:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4E3713858C2C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4E3713858C2C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704361412; cv=none; b=LIdlQYaWDcbzJeJ1pUYvIck9hxJ1vySKbOtArbhSIbxki+0UCMHBtxUmrLZtZfVu3vEkyVNArl0GV04qCePSkW6DBPRmrFj+iiV15usWlVsqnUV5Z3WtgUB4FSB5CpdGTlf2FbPRFjMjiq6h8ANZO2VzWKTCzTtEU1PUxSHtd/k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704361412; c=relaxed/simple; bh=KUWG93ojM5gV1w06TluTk7wmlaPiIkuL9ApH/3VZBDo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=cUmHO299+2iQSU6LHLeSAGsgqXvk5MPgeLWltISNm9YHdqeplnYOQNlgkxXGqTEDBGkGND/UUejvmN8X25G27O6pYKr8bA/+0b8FkmgUyU4pdozERlEAuvUJf7j98HPGBAvfPzDbD3qFoOHbgOkulAedTPIduq9GzV+UIDCLZa0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1704361407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DgLHZqYw030B3uUWYjVb7YoDcKH/TRHsTMT9anrxGwg=; b=BaBeBMWYKFSJ+PlQhJqSbenxoIWHr/Qitm3QBMtojeym0t0BppDbdf4tY5jXJStVjCw9KR 9Y5+tD9mAs19YLMKojbySmr/0yLeQIJR92dfyqFh3RFqZcEs4DBmw7hHwZnNCbE3mGJSln mqVPmDsrDuKnDrEWuDbCixMbcs4I5HY= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-537-FHl7e0NvM1-SiEIAKbBh1A-1; Thu, 04 Jan 2024 04:43:26 -0500 X-MC-Unique: FHl7e0NvM1-SiEIAKbBh1A-1 Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-555b5186361so202402a12.1 for ; Thu, 04 Jan 2024 01:43:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704361405; x=1704966205; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DgLHZqYw030B3uUWYjVb7YoDcKH/TRHsTMT9anrxGwg=; b=UHAvn7eNMY9t9J425mWgQbqJVh/4fWzxfPaUEcHhqb19bq6ab37nOnaoA5kEjFDZG6 0y4UxBVhWdaAdC+1sqeRyFcpg0505UZBxijUtCXwGAeDzaHrE/AhVNezs1B1OXAHdFft W+o+eFJTuXJA04PxYHUTlWJVaknFuj7pbYOBN5zzZvWleMw3zkwH51Ck4GbJJ8aP9VxT LhfyZxUjTW8UuRenIco4STnKXzBZXQRRreJKic6DT9Ra233gjItzxd6W3H6qlqc6Ndy0 iiy4+w+kyn6o9aHPy8At9MhtdesWqzjrIF5n1zWbWy7Z3rLkPC4GvOWG4eLWpKyiKepM rQ+g== X-Gm-Message-State: AOJu0YyZN/Jd+fE6Q6Kw9ISqu+wwb0GswFp6YfGRF5fSeAKDSTqFp+QC Jk/QYknYR7aYhgg+kGkJ1tIiasPL7cFqtvgGjjVsl4jTpQTI0amAgqGvd4llTQIXrgdEcFPqeac gZxQykbtdoyU/YZcvUm7oXK6oDnccZ/fWtFdrNw== X-Received: by 2002:a05:6402:547:b0:556:a28e:613d with SMTP id i7-20020a056402054700b00556a28e613dmr217074edx.23.1704361404871; Thu, 04 Jan 2024 01:43:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IGMY2+8LLSzZCmuJIhAhgh3eiDxGbj49USNbQ/VztL0qqgemTgzAcXESHWRQqBhqu4sf74tFw== X-Received: by 2002:a05:6402:547:b0:556:a28e:613d with SMTP id i7-20020a056402054700b00556a28e613dmr217071edx.23.1704361404545; Thu, 04 Jan 2024 01:43:24 -0800 (PST) Received: from localhost (185.223.159.143.dyn.plus.net. [143.159.223.185]) by smtp.gmail.com with ESMTPSA id v13-20020aa7dbcd000000b00554d57621eesm13820736edt.90.2024.01.04.01.43.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 01:43:24 -0800 (PST) From: Andrew Burgess To: John Baldwin , gdb-patches@sourceware.org Subject: Re: [PATCHv2 0/3] Changes to error reporting from the expression parser In-Reply-To: <45e7649d-ac6d-47da-ac67-618cf85d2f8d@FreeBSD.org> References: <45e7649d-ac6d-47da-ac67-618cf85d2f8d@FreeBSD.org> Date: Thu, 04 Jan 2024 09:43:23 +0000 Message-ID: <871qaxa0xw.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: John Baldwin writes: > On 1/2/24 6:43 AM, Andrew Burgess wrote: >> In V2: >> >> - Have split the "merging of error handling" into its own patch, >> adding the new error handling is in its own patch. >> >> - Reordered patches, the minor bug fix is now first, follow by the >> refactor, with the new functionality placed in the last patch. >> >> - Have dropped the whole marker idea, and gone with the >> simpler 'error at end of ....' style message. This means that no >> tests need updating -- I have added a couple of new tests, but >> everything else should continue to pass as before. >> >> --- >> >> While working on another patch I wished that the error reporting from >> the expression parser was better. This series is my attempt to make >> it better. >> >> --- >> >> Andrew Burgess (3): >> gdb: don't try to style content in error calls >> gdb: merge error handling from different expression parsers >> gdb: improve error reporting from expression parser >> >> gdb/ada-exp.y | 2 +- >> gdb/c-exp.y | 5 +---- >> gdb/d-exp.y | 5 +---- >> gdb/f-exp.y | 5 +---- >> gdb/go-exp.y | 5 +---- >> gdb/m2-exp.y | 5 +---- >> gdb/p-exp.y | 5 +---- >> gdb/parse.c | 15 +++++++++++++++ >> gdb/parser-defs.h | 9 +++++++++ >> gdb/procfs.c | 6 ++---- >> gdb/testsuite/gdb.base/exprs.exp | 8 ++++++++ >> 11 files changed, 41 insertions(+), 29 deletions(-) >> >> >> base-commit: 90827b4eefb06f6e0ab6cbac9eb94922e2cc8aee > > Modulo the one nit I mentioned for the first patch, (and with the > updated comment you noted in your reply to Lancelot SIX), these both > look good to me. > > Approved-By: John Baldwin I took another look at patch #1, I would have sworn I found two places originally, but I can't find a second now .... not sure what happened there. Anyway, I updated the commit message to talk about a single problem case, and pushed this series. Thanks, Andrew