From: Tom Tromey <tom@tromey.com>
To: Guinevere Larsen <blarsen@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v4 0/2] Improving frame printing with recursive calls
Date: Fri, 17 Nov 2023 07:38:32 -0700 [thread overview]
Message-ID: <871qcola1j.fsf@tromey.com> (raw)
In-Reply-To: <20231107124150.116140-2-blarsen@redhat.com> (Guinevere Larsen's message of "Tue, 7 Nov 2023 13:41:49 +0100")
>>>>> "Guinevere" == Guinevere Larsen <blarsen@redhat.com> writes:
Guinevere> This started with the first patch, just fixing PR record/29178. However,
Guinevere> Kevin pointed out that I could reuse some of the local variables to make
Guinevere> the function as a whole simpler, which I did on patch 2.
Guinevere> My changes on v3 introduced a regression in a dwarf2 test. I gave some
Guinevere> time for people to comment on Kevin's solution (then forgot about this
Guinevere> patch), but since no one disagreed, this new version changes thetest,
Guinevere> rather than the code.
These look reasonable to me. Thank you.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2023-11-17 14:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 12:41 Guinevere Larsen
2023-11-07 12:41 ` [PATCH v4 1/2] gdb/record: print frame information when exiting a recursive call Guinevere Larsen
2023-11-07 12:41 ` [PATCH v4 2/2] gdb/infrun: simplify process_event_stop_test Guinevere Larsen
2023-11-17 14:38 ` Tom Tromey [this message]
2023-11-20 9:54 ` [PATCH v4 0/2] Improving frame printing with recursive calls Guinevere Larsen
2023-11-29 11:42 ` Luis Machado
2023-11-29 12:09 ` Guinevere Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qcola1j.fsf@tromey.com \
--to=tom@tromey.com \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).