From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id 2EA073858D33 for ; Fri, 10 Nov 2023 15:18:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2EA073858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2EA073858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699629523; cv=none; b=TtQLZSNSSmLEEYu+WLQ3SljnivMFoVlwheH9ytpy88i6fRUh2NyQOxNWQgROFTuL900SEClbjalfxcqhFG/sh3hitG4CeZZ80LNgJrf/fpSfBAId0FBdmc+9xBBLv8JO2AgdR5K7Dl/DW5u8lO6Q7Jop9R1zdhJkKTEpGQpr4Mc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699629523; c=relaxed/simple; bh=XumoErF3YuRtVsYoGW5dXv+XRTorVBUFC3P2HJneEzs=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=c5Cx1SBEB/d/cE+p7qfYwmn5gSyhPft2lAi2ucC0nsbtBv7aSYh+t/Z+6km5Du0KofF39elVHNmxU9NFdRU3eAApJhjRaDj3G9gkvBHOkdegv8cOb4SNGo8tY4HJrCN9PlShctGr6WKG17fpYk8IeTsZvA0ivAHV+vr9RBU0OOo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-359c1f42680so7740595ab.2 for ; Fri, 10 Nov 2023 07:18:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1699629520; x=1700234320; darn=sourceware.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=nJAsxZ7j9m4rHTrdbKEBVtj9zZ8j0JnmAhFWq1jCUMQ=; b=NoP3rcTGuSgOm5IGnHB27MC+p0aXOCCL287Zn8UHfhWb99laoxAInws5d/ourWxOxL YN4BbNe4ZSXhMNcZ6pfdeyz0GNXL/uJiBWPvDTi007DFHRaUXkI7wn+BlUt6zSZKSGP8 6mO+muwNyS+7734776yVaifqvzyhBJk9hv9tdAQ0LMortbFm2pwqtZhLyy420sgOkrDX dskcXWR9AkSzG/hYj08URuws3n9jr2KUKH1gkV6UiAp+Tc/X3Hg9F1HsanFirmYGlVAe /qLRrQG/3oyZ4IpeSJjhxzTmJSxchtJTz16rQQR1QpjSxdCUzJ/GHoCfS62w+65jvp2+ ikKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699629520; x=1700234320; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=nJAsxZ7j9m4rHTrdbKEBVtj9zZ8j0JnmAhFWq1jCUMQ=; b=Y1hfo5IEzNeUPOJVta1L/SmsDrTptGCTBbfeUr5H+YWcmB5l8f1d++Gtu+adkKLeF/ ZBKqAhSPie6c1wYq/EAwLfe6/wxbYFoQhPMLNfOFa1Wc2VAVjCNhAsPvFdTNI31SgDgX sw/m7fte5cUCr6//7tXoVIwjlG6uQ7RDlu8wSxMwg4zbeGuPbfAH4HT4XXmOzOUgLxia 4BK/cVcRKPm1aVKdXH77gwyzRJAJIjh0nfnJm9lsKvyEuksrlu3NRPgYE8IXsPqjJXBi 3yifB82pjiqMfO08tXJWwvx2pH4qVqPIwe39pOJZ/UfM3fD9kPDHF4Wm+fMXPUOZFlcz oV9w== X-Gm-Message-State: AOJu0YyBrJDziql0UCtCpqS0/ZGFbwUyjIKmzrj/7vN4RVPSTeaek8oq yRLNY5QCbHzfhUsWovKCgd3/pPvJ9XxSl92JOqVkpA== X-Google-Smtp-Source: AGHT+IGPPElv3HweHaSd0YaBUvn5D6uUtXjLuRB0G8g+z66USF3L+STF1/yrP6oyZpQ38NELSh7qGQ== X-Received: by 2002:a05:6e02:1d93:b0:359:6af2:67bb with SMTP id h19-20020a056e021d9300b003596af267bbmr9329128ila.23.1699629520381; Fri, 10 Nov 2023 07:18:40 -0800 (PST) Received: from murgatroyd (97-122-77-73.hlrn.qwest.net. [97.122.77.73]) by smtp.gmail.com with ESMTPSA id j9-20020a926e09000000b00359d156386csm1227846ilc.4.2023.11.10.07.18.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 07:18:39 -0800 (PST) From: Tom Tromey To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Implement the notStopped DAP response References: <20231107-dap-not-stopped-v1-0-3d91c935255d@adacore.com> <20231107-dap-not-stopped-v1-3-3d91c935255d@adacore.com> <878r78bqlk.fsf@adacore.com> <87a5rlvexb.fsf@tromey.com> <871qcxwsgk.fsf@adacore.com> X-Attribution: Tom Date: Fri, 10 Nov 2023 08:18:36 -0700 In-Reply-To: <871qcxwsgk.fsf@adacore.com> (=?utf-8?Q?=22K=C3=A9vin?= Le Gouguec"'s message of "Fri, 10 Nov 2023 16:14:51 +0100") Message-ID: <871qcxvdpv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> Possibly, but it couldn't be called from a non-gdb thread, so we'd have >> to send a message to the gdb thread and then a message back. K=C3=A9vin> Right, thanks for confirming. No strong opinion on my side; if= we are K=C3=A9vin> fine with the notifications, might as well save the roundtrip. Yeah, I tend to think it's ok as-is. >> Originally here I was thinking of putting more event listeners in >> server.py, but it seemed strange not to just reuse the existing ones. K=C3=A9vin> =E2=80=A6 this. The late-import is fine too of course. I ended up just replacing the FIXME with an explanation. Probably the organization here could be improved somehow but it would be just to avoid a local import, which is ugly but more like a pet peeve kind of ugly than something really bad. Tom