From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by sourceware.org (Postfix) with ESMTPS id 8F60A3858428 for ; Fri, 27 Oct 2023 18:08:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8F60A3858428 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8F60A3858428 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698430117; cv=none; b=bZMNsnNHp206GoeGLFLpKIulE7LpTV4wqTnsHncWljyJ62dEVJHEFi6qdUmHtTLy1K+Ug6wcCT9PGmYjtkC06rRA8vW2U/cNqeGpAO5kDINgRy3xHQ7G93vfEKCYHVv6Lc+hF/lxHujKG4gwG/P+Zc1+1ur/97ElaziKKaiLG0s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698430117; c=relaxed/simple; bh=a0ZYXAM++ovigcwEW/k3bktvZ7iKfToEE7CRfdayqzw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=JE++zcrFv7ZwW6pDlJ8k4jpYL5C6aOSPyljS4SqR+clKbFJ5bRYwErAtgNdMfynVvpplKlDTsoSimbq4KD713JGm9dEd60nHcdYfcKP7EbRsEXESYovtx1jOuJoT4U5LJn1E20xvtuY+jieH8xufucqIlwXF6AAY4BMLKKnl5AM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2e.google.com with SMTP id ca18e2360f4ac-7a6774da682so76244139f.3 for ; Fri, 27 Oct 2023 11:08:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1698430116; x=1699034916; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=CehUmRH3QWtfZq9Wax6J8/HGsXil7uHT77heOK/5Nhg=; b=TCBcC0rlIwIRc3xmGCZ/ZuDIHIal2TC3L+Rq2OY1f4LcpmhOLauYufCkgQpCNXg6Zz xqdDWuOOkowSve4L6Lg+12nE3fY2H/oegS4Ba5EA4Dr73OufmQ2w5Q0wmgwflA7PUDO9 Si/MRbjDHKvk8257gnOD13eFhRZu2ntee8tXejGD+VCr2/IHTc6u4BKx2i6Bji3AYeES tdbGnpFZmCIVUlRf0ZINvUMHqLS2CrrQtjKKbQ2At1hr8pQd5TnnCz5KMvsUU6Y7ES6d PYOO8YtXnMCfpBnwzbiC3TJjUNmU1G6w1KIx9e1al8m1DUanmUR2a+afocWfkcnJSeNR vb4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698430116; x=1699034916; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CehUmRH3QWtfZq9Wax6J8/HGsXil7uHT77heOK/5Nhg=; b=VPUbzw84unnr3ojFMo+lFEccRpIHxwrGNTMT/1rh3Fe1nrUK+Tn1A702fkq+cPJ+Q4 FNm2S+ypo1ns+PwxjNAONSKu2DdbLfUsxZEKaRUKZM7fWtIij1SeNfb6+/sw/e6Ms9K/ pVAWr2dXfkqadbO67bGQJ6zhRRIlSNl2yEAUPmVhuO+7/8aOH6EfMPA30ir/UxpvsLrk N518VS9leg4+REnG8fRZK9+MZjwfdfss7JSCfAXppBO9WpDqx9PGA+aSXtyu8436ExW9 o09n8O4CDvq6aaY8TvjWdemjmtOu9rlLHYfzZbaJtzPCgninD1XN7ayVEc1Pl8lXx95b /xJA== X-Gm-Message-State: AOJu0YwBD+V8Yd3tPGppMECALDQn4dEfLD36z7J8yOFpjncbLyVHwBPw WHF7+00JpDOC73fGiZ8O414LGQ== X-Google-Smtp-Source: AGHT+IFi9mWcnATjSZr/UGuKbAGHRozckGATxl/oTmqLQukgMbXRJafB65sblMLOJTqAhnoi2xV2DQ== X-Received: by 2002:a05:6602:2f0b:b0:7a9:984c:1427 with SMTP id q11-20020a0566022f0b00b007a9984c1427mr4606215iow.21.1698430115740; Fri, 27 Oct 2023 11:08:35 -0700 (PDT) Received: from murgatroyd (97-122-77-73.hlrn.qwest.net. [97.122.77.73]) by smtp.gmail.com with ESMTPSA id h12-20020a0566380f8c00b0045539b1a4e6sm525541jal.36.2023.10.27.11.08.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 11:08:34 -0700 (PDT) From: Tom Tromey To: Luis Machado Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/5] Fix calls with small integers on ARM References: <20231020-arm-params-v1-0-19d4c89c11b6@adacore.com> <20231020-arm-params-v1-1-19d4c89c11b6@adacore.com> X-Attribution: Tom Date: Fri, 27 Oct 2023 12:08:34 -0600 In-Reply-To: (Luis Machado's message of "Mon, 23 Oct 2023 14:14:12 +0100") Message-ID: <871qdglyzh.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Luis" == Luis Machado writes: >> @@ -4824,9 +4824,6 @@ arm_push_dummy_call (struct gdbarch *gdbarch, struct value *function, >> { >> /* The argument is being passed in a general purpose >> register. */ >> - if (byte_order == BFD_ENDIAN_BIG) >> - regval <<= (ARM_INT_REGISTER_SIZE - partial_len) * 8; >> - >> arm_debug_printf ("arg %d in %s = 0x%s", argnum, >> gdbarch_register_name (gdbarch, argreg), >> phex (regval, ARM_INT_REGISTER_SIZE)); >> Luis> Do you have an example failure for the above? Is it a positve or Luis> negative integer? I backed this out and ran the internal tests, and it fails on one Ada-specific test involving fixed-point types -- but also on the internal equivalent of this test from gnu_vector.exp: gdb_test "print add_singlevecs((char1) \{6\}, (int1) \{12\}, (double1) \{24\})" "= \\{42\\}" \ "call add_singlevecs" Luis> But looking at it now, it isn't really clear what the Luis> left-shifting is supposed to accomplish, as regval should be Luis> padded/sign-extended from extract_unsigned_integer. Yeah. Tom