From: Thiago Jung Bauermann <thiago.bauermann@linaro.org>
To: Luis Machado <luis.machado@arm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [pushed/obvious] gdb/nat/aarch64-scalable-linux-ptrace.h: Don't include itself
Date: Thu, 26 Oct 2023 10:23:38 -0300 [thread overview]
Message-ID: <871qdhtt45.fsf@linaro.org> (raw)
In-Reply-To: <f33cdd3b-abd4-42c8-989a-8b8e8614ccc1@arm.com>
Hello Luis,
Luis Machado <luis.machado@arm.com> writes:
> On 10/26/23 01:47, Thiago Jung Bauermann wrote:
>> GCC doesn't complain, but it's still wrong.
>> ---
>> gdb/nat/aarch64-scalable-linux-ptrace.h | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> I just spotted the problem, and pushed this patch to fix it under the
>> obvious rule.
>>
>> diff --git a/gdb/nat/aarch64-scalable-linux-ptrace.h
>> b/gdb/nat/aarch64-scalable-linux-ptrace.h
>> index 69c9982b0096..8ff2a96ceb16 100644
>> --- a/gdb/nat/aarch64-scalable-linux-ptrace.h
>> +++ b/gdb/nat/aarch64-scalable-linux-ptrace.h
>> @@ -32,7 +32,6 @@
>> #include <sys/ptrace.h>
>> #include <asm/ptrace.h>
>> #include <stdarg.h>
>> -#include "aarch64-scalable-linux-ptrace.h"
>> #include "aarch64-scalable-linux-sigcontext.h"
>>
>> /* Indicates whether a SVE ptrace header is followed by SVE registers or a
>>
>> base-commit: eefa1c2a6465dff111cf0a3f58269a84ed75115e
>
> Well-spotted. Thanks! It would be nice to have the same pushed to gdb 14.
Good idea. I just pushed to gdb-14-branch.
--
Thiago
next prev parent reply other threads:[~2023-10-26 13:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 0:47 Thiago Jung Bauermann
2023-10-26 8:18 ` Luis Machado
2023-10-26 13:23 ` Thiago Jung Bauermann [this message]
2023-10-26 13:24 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qdhtt45.fsf@linaro.org \
--to=thiago.bauermann@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).