From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by sourceware.org (Postfix) with ESMTPS id 0792F3858D37 for ; Thu, 26 Oct 2023 13:23:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0792F3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0792F3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::102a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698326623; cv=none; b=KFEZ0Igkm0HweZuvOSCWzcrttjZ7JNvv7xWAKt0ry+pEmE2lQkyGrAktct8UkgT+z2p1gOpw+h0S9aXsZPOhCAqiursTiOGfkwFODRrqQmZrK/lwABlAKRYZR8dLaing0mSiyXDr53etnUzgaiiVTN+GqqRl5cS9kWLBqTj3gTE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698326623; c=relaxed/simple; bh=JSy2QCXqbjxjg6Hk48EOLjFXD/tKOfsNnAdfOu75Kck=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=PihzZj0PIrdo5H5OJAtGV2Fpe6VXO0Z1hKu38Qay0ucSTJ4W69YH9iGSNVSRJvLx4jvQuMbq43Wzh+no4W8aYcWknyapVJNA6DCPwoV/oPofdxGPjQXBDZKgedgb31W5C2nQiO/YoxW8l8Y5SA9i6xpTT4KV7jvgrwYzwoLq1NM= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pj1-x102a.google.com with SMTP id 98e67ed59e1d1-27d5c71b4d7so1561961a91.1 for ; Thu, 26 Oct 2023 06:23:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698326621; x=1698931421; darn=sourceware.org; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=YnSS1xhJNyJBcJKLM0ERKIKe5lYqfKeNQeHuAEM8GMU=; b=cR/SVi2tWib9ZwRsF61nmgPs9brJ3NqfxknWiHoaVtQien1U15mBZNKBVhEjyyzvwR 8ia3MUma4M0Y9qJm6tJJIUDMLubPmtN4l8r37RiPDGpaRkJgd8nOYsFs10PrpJXrExxD 4VXVZ57uheJbOAdnaUOdJgjUQ89boyXC4Kwb62o1ybiGqnl/VVAdzFzfhAzhvUIBbKBA RprGnVqNInjOfGKTHhyH+7ujVmuOK3hGN0raNvxuOCo5OPWXDcQyN05P5AFlW2r/dOPd Mtuq6ffDJsqv4W7t+G/67W0Ph0idrs8+PvKCzL2wxDq4CMWonxEeWduRmmkhwr2zOWxb O7bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698326621; x=1698931421; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YnSS1xhJNyJBcJKLM0ERKIKe5lYqfKeNQeHuAEM8GMU=; b=NAb8hMW5UXEPsdYS8boXzj9DENSyHTT9v5gt1fMXH0hA7NkmbSC6SanLJNIjjVDhkg 7cseu7Gs6jU/j1hCsdJEJUbgl1efumVYNtH6/C7fsC8d6xER6JKiaMuVJT6+xlh0OIBh rMBjZ5yPJb/eFBfkGSCLFuhIT2Of7pxhQtfCKGGNL88JDIvpVZiej3kbKuHEzniL/AYt Si3DdimAXEcS4gUFSkJjsNnhHxGrQyatGwgk7kRA/wMyRGPe12U1wmwh++xpbcPxsO+G DF3/fTepMicJFb1JRh7QUJrbdXJ6sAvK8xScNhF1Ciu0O3Pj51vF3IkBiArj4fVund66 ohnQ== X-Gm-Message-State: AOJu0YzMylyNF/cyZrp/x+Zuds6u9/FGx6z28xTou30UHwuQfOk3xbMY dQwv3APSiardNmjIK+9D0Sx5QNAquajCNFTvYi0= X-Google-Smtp-Source: AGHT+IHqgO2iUmu/CjVMA/5WJ8PG/IWiENuj+t/cjGLt5fQPQSDV38cjajGk4UirflXejp6QS0Shsg== X-Received: by 2002:a17:90b:ed7:b0:27d:1b2f:8df1 with SMTP id gz23-20020a17090b0ed700b0027d1b2f8df1mr3445508pjb.14.1698326620896; Thu, 26 Oct 2023 06:23:40 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:bc3a:99e3:6ac:f545]) by smtp.gmail.com with ESMTPSA id lr13-20020a17090b4b8d00b0027cbc50b826sm1655234pjb.17.2023.10.26.06.23.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 06:23:40 -0700 (PDT) References: <20231026004730.28339-1-thiago.bauermann@linaro.org> User-agent: mu4e 1.10.7; emacs 29.1 From: Thiago Jung Bauermann To: Luis Machado Cc: gdb-patches@sourceware.org Subject: Re: [pushed/obvious] gdb/nat/aarch64-scalable-linux-ptrace.h: Don't include itself In-reply-to: Date: Thu, 26 Oct 2023 10:23:38 -0300 Message-ID: <871qdhtt45.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Luis, Luis Machado writes: > On 10/26/23 01:47, Thiago Jung Bauermann wrote: >> GCC doesn't complain, but it's still wrong. >> --- >> gdb/nat/aarch64-scalable-linux-ptrace.h | 1 - >> 1 file changed, 1 deletion(-) >> >> I just spotted the problem, and pushed this patch to fix it under the >> obvious rule. >> >> diff --git a/gdb/nat/aarch64-scalable-linux-ptrace.h >> b/gdb/nat/aarch64-scalable-linux-ptrace.h >> index 69c9982b0096..8ff2a96ceb16 100644 >> --- a/gdb/nat/aarch64-scalable-linux-ptrace.h >> +++ b/gdb/nat/aarch64-scalable-linux-ptrace.h >> @@ -32,7 +32,6 @@ >> #include >> #include >> #include >> -#include "aarch64-scalable-linux-ptrace.h" >> #include "aarch64-scalable-linux-sigcontext.h" >> >> /* Indicates whether a SVE ptrace header is followed by SVE registers or a >> >> base-commit: eefa1c2a6465dff111cf0a3f58269a84ed75115e > > Well-spotted. Thanks! It would be nice to have the same pushed to gdb 14. Good idea. I just pushed to gdb-14-branch. -- Thiago