From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id ED18838560A4 for ; Tue, 19 Sep 2023 16:33:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ED18838560A4 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from eig-obgw-6002a.ext.cloudfilter.net ([10.0.30.222]) by cmsmtp with ESMTP id icY3qzlBEbK1Vidf5qBb3P; Tue, 19 Sep 2023 16:33:19 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id idf4q7xhLM2thidf5qPdpz; Tue, 19 Sep 2023 16:33:19 +0000 X-Authority-Analysis: v=2.4 cv=IN8RtyjG c=1 sm=1 tr=0 ts=6509cd4f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=zNV7Rl7Rt7sA:10 a=Qbun_eYptAEA:10 a=CCpqsmhAAAAA:8 a=I50Wh4nsZ8P6SoNf-WcA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Gfs7+V2IzNQZFW/sj7uw9zR9nMZ2QIc55pSngFK/Q1M=; b=K7b2zpVgJz3MlKbBF+YMBWeZzW 4XK5V4ETN914HQ7UVqYgK5Ocv5Af/cqI4YU0DQL37UOelyX+Q0PzDv/nZjR7JagLS1WO7MqJyDk/j FBmZjcRu3RfLr2HXSjcn0HLup; Received: from 71-211-130-31.hlrn.qwest.net ([71.211.130.31]:57394 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qidf4-0043bq-1k; Tue, 19 Sep 2023 10:33:18 -0600 From: Tom Tromey To: Magne Hov via Gdb-patches Cc: Magne Hov Subject: Re: [PATCH v2 1/2] gdb: keep record of thread numbers for reverse execution targets References: <20230629083651.3145268-1-mhov@undo.io> <20230707162451.3605544-1-mhov@undo.io> <20230707162451.3605544-2-mhov@undo.io> X-Attribution: Tom Date: Tue, 19 Sep 2023 10:33:17 -0600 In-Reply-To: <20230707162451.3605544-2-mhov@undo.io> (Magne Hov via Gdb-patches's message of "Fri, 7 Jul 2023 17:24:50 +0100") Message-ID: <871qeu86nm.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.130.31 X-Source-L: No X-Exim-ID: 1qidf4-0043bq-1k X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-130-31.hlrn.qwest.net (murgatroyd) [71.211.130.31]:57394 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfHVt8RGXP/+5ag6GzJoVWgMGK5TgxuR7AqFWM14aXaB5vMGGfBp6Xu/F1JnBdFU0k5/bmXuktIYgW0AbF6+yiB3AhgY6uqUkKwjChp6JAc8sHMg5+Jpl +QI7vu79juIAvUGHxwlD7Jrq96zU59tVyu8bY82HWtYVnOuo3rNoTCntR6c81mQvOzJCr3KfFRH6p9+Z6MQi9IaIGN5ttIHttwU= X-Spam-Status: No, score=-3018.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Magne" == Magne Hov via Gdb-patches writes: Magne> Targets that support reverse execution may report threads that have Magne> previously been seen to exit. Currently, GDB assigns a new thread Magne> number every time it sees the same thread (re)appearing, but this is Magne> problematic because it makes the output of `info threads` inconsistent, Magne> and because thread-specific breakpoints depend on stable thread-numbers Magne> in order to stop on the right thread. Thank you for the patch. Magne> + std::unordered_map, hash_ptid> ptid_thread_num_map; You'll have to update this for the hash_ptid -> std::hash change. However, that's trivial. Tom