From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by sourceware.org (Postfix) with ESMTPS id CDF193858D3C for ; Fri, 9 Jun 2023 13:42:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CDF193858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12f.google.com with SMTP id e9e14a558f8ab-33be5dbb90cso7585415ab.0 for ; Fri, 09 Jun 2023 06:42:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1686318147; x=1688910147; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=XYipjEd5dI7jsS7mSd0aQyfQodUTjBcXr4IQt5TMn9A=; b=GNX0IcqRytEnZiHIcWEEU8h8hcIH7JKwJdtrtN/X81RE7siTystFE4Wjd4A+04oCrn hQZJDoYclx7nwV00v2R/APOkKn43azbwqFOUHmEl+SR66dGhaBGG18xLSkaXpEZX6X2s lfYHG43NoiEwExenIM18klLy/AJYKILubX/3OuOWb3E4eQ7njljKDxzlGbKCotNPbyxq u96West4PzVSFYRNtC8oVd0qw5SUxqV84+6sO/S8LlIGX4MjAU7y3TZnCY29RXg1B0A6 D/Kx79KkqUMeAp6ZUECErd07bKFslqyTdVZqMyRgWVVVQO202mrj5QjYXdrN0qnpPuu4 /neQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686318147; x=1688910147; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XYipjEd5dI7jsS7mSd0aQyfQodUTjBcXr4IQt5TMn9A=; b=kMILDxb5eJv2jdhlHLYXr8ncoakYuA1ANXcXiFvCuJ8svfLNyegx75UmohAnSzzyWr Q2s7RE7hB7fOXNCD6q2+DAlFL65Dh11HWlapynfOHT6vRF3m8d/qegEtKWvgk13NnXkg kPqKxiC0/BUh4Hw3tJQ9/QbiOCRLvcYKwpW7guqfQevnshJ++AWHHE6A7NQfCUf8oBmw IvA8/uADZ93qK4BwdEfyrq0N1cEgJBsRsWWGYVbDfmbuXIT7jPYLLWgP5xCREeKxtKNI wD5E5Szks9cnYbDdJC4RO730nqw/893ZSCkKBmx2wDJqeXVApL2Iizqt6ipHO5w0TLey 9gVw== X-Gm-Message-State: AC+VfDxlAkR0PCpXKotzTlH2ZH2O6SFgz2zfnj8oEN1yJDQj0nyZMkuU zRL7gTcdpZIcYcB5rONKw+XV8Q== X-Google-Smtp-Source: ACHHUZ4p0TLV/WfZC3fs1dV4uDrcIaa7ArI0LMFex3xTkhmMsH6jLW8G5ogGpWzojK64JFnYhvKIJA== X-Received: by 2002:a92:1e03:0:b0:33a:ec53:fce4 with SMTP id e3-20020a921e03000000b0033aec53fce4mr1480425ile.32.1686318146946; Fri, 09 Jun 2023 06:42:26 -0700 (PDT) Received: from murgatroyd (75-166-136-83.hlrn.qwest.net. [75.166.136.83]) by smtp.gmail.com with ESMTPSA id x5-20020a92d305000000b0032aef6b60adsm1086655ila.34.2023.06.09.06.42.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Jun 2023 06:42:26 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Use scoped_value_mark in two more places References: <20230525125737.1849340-1-tromey@adacore.com> X-Attribution: Tom Date: Fri, 09 Jun 2023 07:42:25 -0600 In-Reply-To: <20230525125737.1849340-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Thu, 25 May 2023 06:57:37 -0600") Message-ID: <871qikah1a.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> I found a couple of spots that could use scoped_value_mark. One of Tom> them is a spot that didn't consider the possibility that value_mark Tom> can return NULL. I tend to doubt this can be seen in this context, Tom> but nevertheless this is safer. Tom> Regression tested on x86-64 Fedora 36. I'm checking this in. Tom