From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id D80583858D20 for ; Tue, 30 May 2023 17:28:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D80583858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id 4670110047F9A for ; Tue, 30 May 2023 17:28:26 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 4390qgv6UuM0S4390qMh3s; Tue, 30 May 2023 17:28:26 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=CPPv4TnD c=1 sm=1 tr=0 ts=6476323a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=P0xRbXHiH_UA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=ZhHIJghI9HnRJzY5K2kA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Atgp9yGBb7XJFdHJksrsOLwFPLqseupEtbl4f0eYQAM=; b=C8D8PEyYNQFBJcNRp9AGpwcUcs Yhfryi9gx/geozVg0Vt4En1Hrmz8gNfjU2lhgUc0qntTmR6GY6HgMq1zYCT2kOuoB9JRRvO05hhPD MHPvkeriN6iRluT96EXRNzaGE; Received: from 71-211-130-244.hlrn.qwest.net ([71.211.130.244]:49390 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q438z-000Rh2-Vk; Tue, 30 May 2023 11:28:26 -0600 From: Tom Tromey To: Ed Catmur Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Support DW_TAG_GNU_formal_parameter_pack and DW_TAG_GNU_template_parameter_pack. References: <20230115224242.29922-1-ed@catmur.uk> X-Attribution: Tom Date: Tue, 30 May 2023 11:28:25 -0600 In-Reply-To: <20230115224242.29922-1-ed@catmur.uk> (Ed Catmur's message of "Sun, 15 Jan 2023 22:42:42 +0000") Message-ID: <871qixwwxy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.130.244 X-Source-L: No X-Exim-ID: 1q438z-000Rh2-Vk X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-130-244.hlrn.qwest.net (murgatroyd) [71.211.130.244]:49390 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Ed" == Ed Catmur writes: Hi. I'm sorry about the long delay on this review. Unfortunately in gdb you have to send pings for patches. Ed> https://sourceware.org/bugzilla/show_bug.cgi?id=17272 Ed> Synthesize type and parameter names as T#n, p#n e.g. Args#1, args#1. Ed> This is a pretty simple approach but it seems to work OK and is Ed> compatible with the old style type and parameter names emitted by Ed> old versions of gcc and when it's writing stabs+ format. Does stabs even handle template parameter packs? Also are synthesized names really necessary? If they aren't required in DWARF perhaps they can just be nullptr. Ed> - attr = dwarf2_attr (die, Ed> + struct die_info *line_file_die = die; Ed> + if (die->tag == DW_TAG_formal_parameter && die->parent && die->parent->tag == DW_TAG_GNU_formal_parameter_pack) This line looks too long. There are other minor formatting issues as well, for example in the GNU style there is usually a space before an open paren. Ed> + size = snprintf(NULL, 0, "%s#%d", parent_name, ordinal) + 1; Ed> + name = ((char *) obstack_alloc (&cu->per_objfile->per_bfd->obstack, size)); Ed> + snprintf(name, size, "%s#%d", parent_name, ordinal); gdb doesn't generally use snprintf. There are other options, like printing to a string and then copying it. A patch like this needs a test case. Also I'm curious if this works ok with the Python API. Tom