Re: [PATCHv3 2/2] gdb/python: extend the Python Disassembler API to allow for styling

[Andrew Burgess <aburgess@redhat.com>]

Tom de Vries <tdevries@suse.de> writes:

> On 5/17/23 19:46, Andrew Burgess wrote:
>> Tom de Vries <tdevries@suse.de> writes:
>> 
>>> On 5/12/23 19:50, Andrew Burgess via Gdb-patches wrote:
>>>> This commit extends the Python Disassembler API to allow for styling
>>>> of the instructions.
>>>>
>>>
>>> I'm running into:
>>> ...
>>> FAIL: gdb.python/py-disasm.exp:
>>> global_disassembler=ErrorCreatingTextPart_NoArgs: disassemble test
>>> FAIL: gdb.python/py-disasm.exp:
>>> global_disassembler=ErrorCreatingAddressPart_NoArgs: disassemble test
>>> FAIL: gdb.python/py-disasm.exp:
>>> global_disassembler=ErrorCreatingTextPart_NoString: disassemble test
>>> FAIL: gdb.python/py-disasm.exp:
>>> global_disassembler=ErrorCreatingTextPart_NoStyle: disassemble test
>>> FAIL: gdb.python/py-disasm.exp: try to create a DisassemblerResult
>>> without a length argument
>>> ...
>>>
>>> First in more detail:
>>> ...
>>> (gdb) disassemble test^M
>>> Dump of assembler code for function test:^M
>>>      0x00000000004004a7 <+0>:     push   %rbp^M
>>>      0x00000000004004a8 <+1>:     mov    %rsp,%rbp^M
>>>      0x00000000004004ab <+4>:     nop^M
>>> => 0x00000000004004ac <+5>:     Python Exception <class 'TypeError'>:
>>> Required argument 'style' (pos 1) not found^M
>>> ^M
>>> unknown disassembler error (error = -1)^M
>>> (gdb) FAIL: gdb.python/py-disasm.exp:
>>> global_disassembler=ErrorCreatingTextPart_NoArgs: disassemble test
>>> ...
>>>
>>> This seems to be due to the test-case expecting " function missing
>>> required argument ..." but getting "Required argument ..."
>> 
>> Sorry for that.
>
> Np of course :)
>
>>  I guess you must be using an older (3.6.x or earlier)
>> version of Python?
>> 
>
> /me checks:
> ...
> $ python3 --version
> Python 3.6.15
> ...
> Yes.
>
>> The patch below should resolve the issues, I'll push this tomorrow.
>> 
>
> I've checked, it does, thanks.
>

Thanks for checking.  I pushed this patch.

Thanks,
Andrew