Re: [PATCH v2] gdb: fix post-hook execution for remote targets

[Tom Tromey <tom@tromey.com>]

>>>>> "Jan" == Jan Vrany via Gdb-patches <gdb-patches@sourceware.org> writes:

>> I wonder if it would be possible to reimplement dont_repeat so that it
>> does not overwrite the command.  Like, could it just set a flag?

Jan> Yes, that'd make things clear. I tried couple things but each time
Jan> something broke.

Yeah, the older the code is, the more likely it is to have some bizarre
hidden dependency.

Jan> Here we compare the value of saved_command_line so we cannot easily
Jan> set the flag and then when reading input and flag is set, return empty string
Jan> instead of saved_command_line. Truth to be told, I don't understand how it works
Jan> and what exactly (for example) the code above does or why it is needed. 

Me too.

Jan> I checked that with my version of GCC, std::string s = nullptr; throws an
Jan> error and abort()s but I could not find a situation when p == NULL.

It's possible that there isn't a case, but also possible that it's just
never tested.  Difficult to reason about these things.

Anyway, this is ok.

Approved-By: Tom Tromey <tom@tromey.com>

Tom