From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by sourceware.org (Postfix) with ESMTPS id C63EC3858C54 for ; Fri, 12 May 2023 18:30:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C63EC3858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd34.google.com with SMTP id ca18e2360f4ac-76c4bb969faso146189139f.3 for ; Fri, 12 May 2023 11:30:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1683916249; x=1686508249; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=LU67r2Ia3XSgxNbgXiBgc8l7ece8/ua2nltYEQrPl4E=; b=gvkcfP4R/qO3EApBf2yZ4mUJ1Mph1MV0mdtraw60/3CDn/8WLd+EL6D/Y61OaEHkao lCbuLkLzVCbJAxebEWGYLaqKmk85NMTwjAn4fD3sDAZJZaDP2Lam64HR+mGegpOgUA1V ua78rB2HtlXITbPihv+1+/iUKFD6bEp38XBK5t5D9CxADbwmhQszYLE0qrrYZIWm5Zay CqXHfLqXoINCjLO9DWtURpmQSY3lAChzkxNxPymgNJtFIilRjPTn7ayORS9dGYRp/6nZ S3LdUHtgYdE1rjhcFd0eh42Yi/NpFSXhPTVYpt9Fh5HAt9vV8r0RrQK1bZ7vIWlZdocX bWyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683916249; x=1686508249; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LU67r2Ia3XSgxNbgXiBgc8l7ece8/ua2nltYEQrPl4E=; b=WkA69s0rXGMpKaO0pCmfZNi/OB2U4CoFnH5JHreQV3V31YGzopIGoFn16e3LEcdoWI HAY+JKtMIKhXslL9I/vWFklY18T9NOPROd0/4bxB611UuT5KjXKZAqXEIsSobNlGyZ7O dsohjTF0zOmMIu6qIathxbSn/pqXcbEUyWXUZJdpceiY1hyPq2eB7u+FSa3rBWnviw3Q xYPPo/vVLKdXduLh92OI/XOuYJsDEq+k2koebqQ1ScqJr75n/9eV0A+J8DB9cjxl77or UGYrQ4Zj8U84JiNptoJmDDEcba2lIdRskulH1xlAUz3HJZ91paPBLNtcuqyklzsCDQDC 5N3w== X-Gm-Message-State: AC+VfDz++Ph7j3PrFYawj1cQOYAxklSzVIEr1rXEYEZNPip5fPFtf0OX eLRcKw5vqmpgQ6U3nyhR5Hh0Uw== X-Google-Smtp-Source: ACHHUZ4s2+QDZAINhX5mF8oTqAaM8xbQIzUu8h74OVJaHBWnfv61ZhzS6qw/V0saB1avCDNEznAhNA== X-Received: by 2002:a6b:d815:0:b0:763:5f51:aff7 with SMTP id y21-20020a6bd815000000b007635f51aff7mr17119052iob.5.1683916249087; Fri, 12 May 2023 11:30:49 -0700 (PDT) Received: from murgatroyd (75-166-157-55.hlrn.qwest.net. [75.166.157.55]) by smtp.gmail.com with ESMTPSA id m1-20020a02c881000000b0041407c67451sm5217468jao.165.2023.05.12.11.30.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 May 2023 11:30:48 -0700 (PDT) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Add dynamic_prop::is_constant References: <20230427182906.325477-1-tromey@adacore.com> X-Attribution: Tom Date: Fri, 12 May 2023 12:30:48 -0600 In-Reply-To: <20230427182906.325477-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Thu, 27 Apr 2023 12:29:06 -0600") Message-ID: <871qjl4d2f.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> I noticed many spots checking whether a dynamic property's kind is Tom> PROP_CONST. Some spots, I think, are doing a slightly incorrect check Tom> -- checking for != PROP_UNDEFINED where == PROP_CONST is actually Tom> required, the key thing being that const_val may only be called for Tom> PROP_CONST properties. Tom> This patch adds dynamic::is_constant and then updates these checks to Tom> use it. Tom> Regression tested on x86-64 Fedora 36. I'm checking this in. Tom