From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 05C463858D1E for ; Tue, 25 Apr 2023 20:22:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 05C463858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 51DE610047C24 for ; Tue, 25 Apr 2023 20:22:00 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id rPAmpyMJ7UwlvrPAmpZ7UW; Tue, 25 Apr 2023 20:22:00 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=BbEdbph2 c=1 sm=1 tr=0 ts=64483668 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=dKHAf1wccvYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=20KFwNOVAAAA:8 a=CCpqsmhAAAAA:8 a=BnTfsbuGs5pv6syMTZMA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+PBypJFRpWsjz4dYcAnGytk/OtBEd4sHk7JxYx4Nt48=; b=r2uH54hlqtEKwN5yy47fHMhwNY /AyWwS4fT3VIQcqHm1N8H0acjDjkABk8XHVwFrt5GXz4vmYW8u6yA+BjGgVLIgKN/JqXvO4egB4lt 3QSoIOfi+//1Zup8RMyqbcNTg; Received: from 71-211-191-82.hlrn.qwest.net ([71.211.191.82]:51862 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1prPAm-0018YH-09; Tue, 25 Apr 2023 14:22:00 -0600 From: Tom Tromey To: Keith Seitz Cc: Tom Tromey , Keith Seitz via Gdb-patches Subject: Re: [PATCH] Allow strings with printf/eval References: <20230423172131.1104908-1-keiths@redhat.com> <87r0s9xkyu.fsf@tromey.com> <514297cf-4c9e-f6bb-95f3-3ebdec9bb13e@redhat.com> X-Attribution: Tom Date: Tue, 25 Apr 2023 14:21:59 -0600 In-Reply-To: <514297cf-4c9e-f6bb-95f3-3ebdec9bb13e@redhat.com> (Keith Seitz's message of "Tue, 25 Apr 2023 08:50:54 -0700") Message-ID: <871qk7pva0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.191.82 X-Source-L: No X-Exim-ID: 1prPAm-0018YH-09 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-191-82.hlrn.qwest.net (prentzel) [71.211.191.82]:51862 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Keith" == Keith Seitz writes: Keith> On 4/24/23 10:12, Tom Tromey wrote: >>>>>>> "Keith" == Keith Seitz via Gdb-patches writes: Keith> (gdb) printf "%s\n", "hello" Keith> evaluation of this expression requires the target program to be active >> This is https://sourceware.org/bugzilla/show_bug.cgi?id=13098 Keith> Thank you for that bz; I will add a reference in the commit log. Keith> - if (value->type ()->code () != TYPE_CODE_PTR Keith> - && value->lval () == lval_internalvar Keith> + if (((value->type ()->code () != TYPE_CODE_PTR && value->lval () == lval_internalvar) Keith> + || (value->type ()->code () == TYPE_CODE_ARRAY && value->lval () == not_lval)) >> I wonder if lval check is necessary here. Keith> It does not appear to be, but I erred on the overly conservative side when Keith> implementing the change. Regression testing shows no differences when Keith> removing that lval check. Keith> I've removed it locally. I think with those 2 small changes, the patch is ok. Thank you. Tom