From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by sourceware.org (Postfix) with ESMTPS id D11D73858CDA for ; Thu, 30 Mar 2023 03:52:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D11D73858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x236.google.com with SMTP id bm2so13287363oib.4 for ; Wed, 29 Mar 2023 20:52:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680148370; x=1682740370; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:from:to:cc:subject:date:message-id:reply-to; bh=Xdos75NdXnL6j2LgoZH/flWfic1fBEZ7EJ2bZ9O0eSg=; b=Q5oifKC+Z6J+pK6NvbDEjcMXgF6YvlAJedym5qpe1AZ5dB96ZWZC4EU2LqTxSzc6F3 tuWIKQ1+zCn0oCUZgoSA24B3/UlLxvvzjsBJZqC1bGYnbscgV4OqIsG/9+UOxpmNkpx/ HO4mGbSzIyHEw3U0avhyDEZ+iRu9exekT13rfZe1rTsPw6azsc6m/846DLFLXwNWsXBJ 08jxiWJKFO8Tz59tmJKjM/ZGPcvdl/wH7YMA+MeLvgWXPo931Sxsd6DCycJYkCGydC1X 5NpPM9Msc/yZRnZRQECa3b7x7kmwkk6PZJJ9fU0t+ZDxmNlrAhefC1tcDaWN6FmLlYmy JH5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680148370; x=1682740370; h=mime-version:message-id:date:in-reply-to:subject:cc:to:from :user-agent:references:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Xdos75NdXnL6j2LgoZH/flWfic1fBEZ7EJ2bZ9O0eSg=; b=MNEemluq0htj2fWaFVvHyM2kp2sRab/z+axxBUUpdM+tHEIPlqbCGRqqzic7iWpE/3 pB1df/utTTJPZDuzBxlW3iIf+Q0P1/h+8KWcl06Ys3tZHFjVq3ojUafgym/k+i2Ty08v Nw5u4CtLV6QuFAp1v2XEFNwST2wBCEchQniMfS9kzKIdvqOXsnxbvjxUXvyceYVOQ+CJ eB+5g6PGVG/TnfXwvA61mHSxs1DHIFTKEcBZSOMKatDksSlk88G6V80mLynnLWfaAZtD 8hnZi0oBekSKBkAnLAVfyiOGBYDQEezhEkHAapT/E0sNPJWIJ3IUzHzpcB4e7Ym67fhM COFg== X-Gm-Message-State: AAQBX9c/ibLzSUUX7tVLKTiS2p1500O8Ude3YdiYvRf2VDfZTdFfNVzy 5FluTDUAPhNZ29nRU96F/0lGAbwmmb69HDM00dE= X-Google-Smtp-Source: AKy350YpgaHVZX9i5ui4IdNe4CAlT5JGAAYQ614otZ4WIFesHGu/NEJvaQhZZiWYBhf3RdaOOfMB+Q== X-Received: by 2002:aca:280c:0:b0:389:72d5:f16f with SMTP id 12-20020aca280c000000b0038972d5f16fmr951838oix.28.1680148370139; Wed, 29 Mar 2023 20:52:50 -0700 (PDT) Received: from localhost ([177.124.15.238]) by smtp.gmail.com with ESMTPSA id z14-20020a54458e000000b0037b6f5d6309sm7714514oib.2.2023.03.29.20.52.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Mar 2023 20:52:49 -0700 (PDT) References: <20230321-submit-unrelocated-type-v1-0-2a1fb6117abf@tromey.com> <20230321-submit-unrelocated-type-v1-5-2a1fb6117abf@tromey.com> User-agent: mu4e 1.8.13; emacs 28.2 From: Thiago Jung Bauermann To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 5/6] Use unrelocated_addr in minimal symbols In-reply-to: <20230321-submit-unrelocated-type-v1-5-2a1fb6117abf@tromey.com> Date: Thu, 30 Mar 2023 03:52:47 +0000 Message-ID: <871ql6dhf4.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, Tom Tromey writes: > This changes minimal symbols to use unrelocated_addr. I believe this > detected a latent bug in add_pe_forwarded_sym. This caused a regression on aarch64-linux. Previously gdb.asm/asm-source.exp passed all tests, but now: Running /home/thiago.bauermann/src/binutils-gdb/gdb/testsuite/gdb.asm/asm-source.exp ... PASS: gdb.asm/asm-source.exp: f at main PASS: gdb.asm/asm-source.exp: n at main PASS: gdb.asm/asm-source.exp: next over macro FAIL: gdb.asm/asm-source.exp: step into foo2 PASS: gdb.asm/asm-source.exp: info target PASS: gdb.asm/asm-source.exp: info symbol PASS: gdb.asm/asm-source.exp: list PASS: gdb.asm/asm-source.exp: search FAIL: gdb.asm/asm-source.exp: f in foo2 FAIL: gdb.asm/asm-source.exp: n in foo2 (the program exited) FAIL: gdb.asm/asm-source.exp: bt ALL in foo2 FAIL: gdb.asm/asm-source.exp: bt 2 in foo2 PASS: gdb.asm/asm-source.exp: s 2 PASS: gdb.asm/asm-source.exp: n 2 FAIL: gdb.asm/asm-source.exp: bt 3 in foo3 PASS: gdb.asm/asm-source.exp: info source asmsrc1.s FAIL: gdb.asm/asm-source.exp: finish from foo3 (the program is no longer running) FAIL: gdb.asm/asm-source.exp: info source asmsrc2.s PASS: gdb.asm/asm-source.exp: info sources FAIL: gdb.asm/asm-source.exp: info line FAIL: gdb.asm/asm-source.exp: next over foo3 (the program is no longer running) FAIL: gdb.asm/asm-source.exp: return from foo2 PASS: gdb.asm/asm-source.exp: look at global variable PASS: gdb.asm/asm-source.exp: x/i &globalvar PASS: gdb.asm/asm-source.exp: disassem &globalvar, (int *) &globalvar+1 PASS: gdb.asm/asm-source.exp: look at static variable PASS: gdb.asm/asm-source.exp: x/i &staticvar PASS: gdb.asm/asm-source.exp: disassem &staticvar, (int *) &staticvar+1 PASS: gdb.asm/asm-source.exp: look at static function The failures happen because GDB isn't able to step into foo2 anymore, and steps over it instead: (gdb) PASS: gdb.asm/asm-source.exp: next over macro s^M 53 gdbasm_exit0^M (gdb) FAIL: gdb.asm/asm-source.exp: step into foo2 I'm currently investigating. -- Thiago