public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Aaron Merey via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tom@tromey.com>,  Aaron Merey <amerey@redhat.com>
Subject: Re: [PATCH] gdb/debuginfod: Prevent prompt for continue during downloading.
Date: Mon, 13 Feb 2023 07:17:59 -0700	[thread overview]
Message-ID: <871qmtwsx4.fsf@tromey.com> (raw)
In-Reply-To: <CAJDtP-S30d5GV_nkk+hzOxrOU7xyvJJ3Dwzs7Nd=eTCFds+-+w@mail.gmail.com> (Aaron Merey via Gdb-patches's message of "Fri, 10 Feb 2023 21:02:19 -0500")

>>>>> "Aaron" == Aaron Merey via Gdb-patches <gdb-patches@sourceware.org> writes:

Aaron> However the on-demand downloading work creates new situations where
Aaron> a large series of downloads might happen outside fetch_inferior_event.
Aaron> For example, "break client.c:50" could download the .debug_line and
Aaron> .debug_line_str of each shared library to search for the filename
Aaron> "client.c". Then it downloads debuginfo for each match, all of which
Aaron> happens outside of fetch_inferior_event.

Aaron> Setting pagination_enabled=false in debuginfod_*_query prevents the
Aaron> prompt durings the downloads but lines_printed keeps increasing.
Aaron> If lines_allowed is exceeded then after the download you get an (IMO)
Aaron> annoying prompt:

I think this is what the user has requested, though.
The pager can easily be disabled, but if we let code work around it,
there's not really any way to ask for it to be enabled again.

Aaron> Adding a count_lines_printed flag gives us another way to fine-tune
Aaron> when the prompt shows up.  It keeps prompt behavior around debuginfod
Aaron> output consistent whether or not the inferior is running.

This is an internal distinction but it seems to me that to the user, gdb
output is just gdb output and can't really be differentiated by its
origin.

Tom

  reply	other threads:[~2023-02-13 14:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-28  4:06 Aaron Merey
2023-01-28 15:01 ` Tom Tromey
2023-01-31  2:09   ` Aaron Merey
2023-01-31 14:22     ` Tom Tromey
2023-01-31 20:41       ` Aaron Merey
2023-02-08 14:44         ` Tom Tromey
2023-02-11  2:02           ` Aaron Merey
2023-02-13 14:17             ` Tom Tromey [this message]
2023-02-13 20:23               ` Aaron Merey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871qmtwsx4.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=amerey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).